getComputedStyle should handle over-constrained properties.

getComputedStyle should handle over-constrained properties.

If neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning

BUG=601118
Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05
Cr-Commit-Position: refs/heads/master@{#394780}

[Deokjin Kim, 2016-05-18 12:21:59]

Description was changed from

==========
WIP_601118

BUG=601118
==========

to

==========
getComputedStyle should handle over-constrained properties.
    
IF neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
    
BUG=601118
==========

[Deokjin Kim, 2016-05-18 12:21:59]

deokjin81.kim@samsung.com changed reviewers:
+ alancutter@chromium.org, eae@chromium.org, mstensho@opera.com, rune@opera.com

[Deokjin Kim, 2016-05-18 12:24:07]

Description was changed from

==========
getComputedStyle should handle over-constrained properties.
    
IF neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
    
BUG=601118
==========

to

==========
getComputedStyle should handle over-constrained properties.
    
If neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
    
BUG=601118
==========

[Deokjin Kim, 2016-05-18 12:27:29]

PTAL. Thank you in advance.

[eae, 2016-05-18 17:49:39]

eae@chromium.org changed reviewers:
+ timloh@chromium.org

[eae, 2016-05-18 17:49:40]

Tim would be a better reviewer for this.

[rune, 2016-05-18 21:41:08]

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:251: if
(!offset.isAuto() && layoutObject->isInFlowPositioned()) {
offset is not auto at this point, so no need to check it. Did you mean to check
opposite here?

[Deokjin Kim, 2016-05-18 23:29:55]

I changed "if" statement. Check whether opposite is auto, not offset. Would you
please review this CL? Thank you~

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:251: if
(!offset.isAuto() && layoutObject->isInFlowPositioned()) {
On 2016/05/18 21:41:07, rune wrote:
> offset is not auto at this point, so no need to check it. Did you mean to
check
> opposite here?

You're right. It's typo. I intended to use opposite, not offset.

[mstensho (USE GERRIT), 2016-05-19 05:57:52]

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:251: if
(!offset.isAuto() && layoutObject->isInFlowPositioned()) {
On 2016/05/18 23:29:55, Deokjin Kim wrote:
> On 2016/05/18 21:41:07, rune wrote:
> > offset is not auto at this point, so no need to check it. Did you mean to
> check
> > opposite here?
> 
> You're right. It's typo. I intended to use opposite, not offset.

No tests failed because of the typo? Then I think we need another test.

[Deokjin Kim, 2016-05-19 12:57:24]

I added 1 more test case. Would you please review this CL? Thank you~

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/1988813002/diff/40002/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:251: if
(!offset.isAuto() && layoutObject->isInFlowPositioned()) {
On 2016/05/19 05:57:52, mstensho wrote:
> On 2016/05/18 23:29:55, Deokjin Kim wrote:
> > On 2016/05/18 21:41:07, rune wrote:
> > > offset is not auto at this point, so no need to check it. Did you mean to
> > check
> > > opposite here?
> > 
> > You're right. It's typo. I intended to use opposite, not offset.
> 
> No tests failed because of the typo? Then I think we need another test.

I added 1 more test
case(fast/css/getComputedStyle/getComputedStyle-right-auto.html). With checking
offset, this is failed. But with checking opposite, this is passed.

[rune, 2016-05-19 13:08:24]

lgtm

[Deokjin Kim, 2016-05-19 13:18:04]

The CQ bit was checked by deokjin81.kim@samsung.com

[commit-bot: I haz the power, 2016-05-19 13:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988813002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988813002/80001

[Deokjin Kim, 2016-05-19 14:45:19]

The CQ bit was checked by deokjin81.kim@samsung.com

[Deokjin Kim, 2016-05-19 14:45:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/1988813002/#ps100001
(title: "Update test case's expected file")

[commit-bot: I haz the power, 2016-05-19 14:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988813002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988813002/100001

[commit-bot: I haz the power, 2016-05-19 15:52:19]

Description was changed from

==========
getComputedStyle should handle over-constrained properties.
    
If neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
    
BUG=601118
==========

to

==========
getComputedStyle should handle over-constrained properties.
    
If neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
    
BUG=601118
==========

[commit-bot: I haz the power, 2016-05-19 15:52:21]

Committed patchset #7 (id:100001)

[commit-bot: I haz the power, 2016-05-19 15:53:39]

Description was changed from

==========
getComputedStyle should handle over-constrained properties.
    
If neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
    
BUG=601118
==========

to

==========
getComputedStyle should handle over-constrained properties.

If neither 'left' nor 'right' is 'auto', the position is over-constrained,
and one of them has to be ignored. If 'direction' property of the
containing block is 'ltr', the value of 'left' wins and 'right'
becomes -'left'. If 'direction' of the containing block is 'rtl',
'right' wins and 'left' is ignored. Detail is described by
https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning

BUG=601118

Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05
Cr-Commit-Position: refs/heads/master@{#394780}
==========

[commit-bot: I haz the power, 2016-05-19 15:53:41]

Patchset 7 (id:??) landed as
https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05
Cr-Commit-Position: refs/heads/master@{#394780}

[Deokjin Kim, 2016-05-27 10:57:14]

A revert of this CL (patchset #7 id:100001) has been created in
https://codereview.chromium.org/2016913003/ by deokjin81.kim@samsung.com.

The reason for reverting is: Other vendors didn't implement this yet. And work
with the others to either get all to fix or to change the spec.

BUG=614198.