Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 19888007: Bold and Italic style get stuck when applied on a selection having content with mixed editability (Closed)

Created:
7 years, 5 months ago by vanihegde
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Bold and Italic style get stuck when applied on a selection having content with mixed editability When bold/italic style is applied to a content with mixed editability, style is applied appropriately for the first time. But after this, style toggling does not work any more. Same behavior can be observed when the content on which style is applied contains text node without renderer (Ex: text node corresponding to tab/space etc). When bold/italic style is applied on a selection, we actually apply the style only for text nodes that have renderers and also are contenteditable. Similarly during style toggling, to check whether a style has been already applied on a selection, we should be considering only those text nodes that have renderers and are contenteditable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155246

Patch Set 1 #

Patch Set 2 : Bold and Italic style get stuck when applied on a selection having content with mixed editability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -11 lines) Patch
M LayoutTests/editing/editing.js View 1 2 chunks +12 lines, -3 lines 0 comments Download
A LayoutTests/editing/style/toggle-style-bold-italic.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/editing/style/toggle-style-bold-italic-expected.txt View 1 1 chunk +70 lines, -0 lines 0 comments Download
A LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability-expected.txt View 1 1 chunk +68 lines, -0 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vanihegde
Webkit bug for this issue https://bugs.webkit.org/show_bug.cgi?id=118185
7 years, 5 months ago (2013-07-23 10:03:37 UTC) #1
vanihegde
7 years, 5 months ago (2013-07-26 08:24:33 UTC) #2
vanihegde
This patch has already been reviewed & committed in webkit http://trac.webkit.org/changeset/153509 Please have a look
7 years, 4 months ago (2013-07-31 06:21:44 UTC) #3
vanihegde
This patch has already been reviewed & committed in webkit http://trac.webkit.org/changeset/153509 Please have a look
7 years, 4 months ago (2013-07-31 06:21:44 UTC) #4
eseidel
lgtm
7 years, 4 months ago (2013-07-31 06:28:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/19888007/4001
7 years, 4 months ago (2013-07-31 06:29:37 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=602
7 years, 4 months ago (2013-07-31 10:43:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/19888007/4001
7 years, 4 months ago (2013-07-31 13:46:24 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 14:41:49 UTC) #9
Message was sent while issue was closed.
Change committed as 155246

Powered by Google App Engine
This is Rietveld 408576698