Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: runtime/vm/isolate_reload.cc

Issue 1988763004: Fix tests by removing broken (and unneeded) code from isolate_reload.cc (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate_reload.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload.cc
diff --git a/runtime/vm/isolate_reload.cc b/runtime/vm/isolate_reload.cc
index faf44a1cff73c400c0b69d61980c37d8b94ee510..02915170900afab0a66db91763b2e38268e95b46 100644
--- a/runtime/vm/isolate_reload.cc
+++ b/runtime/vm/isolate_reload.cc
@@ -656,31 +656,6 @@ void IsolateReloadContext::VerifyMaps() {
}
class_map.Release();
}
-
-
-void IsolateReloadContext::VerifyCanonicalTypeArguments() {
- Thread* thread = Thread::Current();
- const Array& table =
- Array::Handle(Z, I->object_store()->canonical_type_arguments());
- const intptr_t table_size = table.Length() - 1;
- ASSERT(Utils::IsPowerOfTwo(table_size));
- TypeArguments& element = TypeArguments::Handle(Z);
- TypeArguments& other_element = TypeArguments::Handle();
- for (intptr_t i = 0; i < table_size; i++) {
- element ^= table.At(i);
- for (intptr_t j = 0; j < table_size; j++) {
- if ((i != j) && (table.At(j) != TypeArguments::null())) {
- other_element ^= table.At(j);
- if (element.Equals(other_element)) {
- // Recursive types may be equal, but have different hashes.
- ASSERT(element.IsRecursive());
- ASSERT(other_element.IsRecursive());
- ASSERT(element.Hash() != other_element.Hash());
- }
- }
- }
- }
-}
#endif
@@ -809,11 +784,6 @@ void IsolateReloadContext::Commit() {
libs.Length());
}
}
-
-#ifdef DEBUG
- // TODO(turnidge): Remove before committing to main branch.
- VerifyCanonicalTypeArguments();
-#endif
}
« no previous file with comments | « runtime/vm/isolate_reload.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698