Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1988713007: gn/mac: Build cc_blink_unittests (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek, danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn/mac: Build cc_blink_unittests This seems to Just Work. BUG=612528 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e87a03db441fbf78968898ba0078aef67d6b62a8 Cr-Commit-Position: refs/heads/master@{#394248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M cc/blink/BUILD.gn View 1 chunk +20 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Nico
rsesek for gn expertise, danakj for owner stamping
4 years, 7 months ago (2016-05-17 20:07:31 UTC) #3
Robert Sesek
LGTM. Do these run on any bots?
4 years, 7 months ago (2016-05-17 20:26:25 UTC) #4
danakj
LGTM
4 years, 7 months ago (2016-05-17 20:29:42 UTC) #5
danakj
On 2016/05/17 20:26:25, Robert Sesek wrote: > LGTM. Do these run on any bots? They ...
4 years, 7 months ago (2016-05-17 20:30:09 UTC) #6
Nico
On 2016/05/17 20:26:25, Robert Sesek wrote: > LGTM. Do these run on any bots? Doesn't ...
4 years, 7 months ago (2016-05-17 20:31:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988713007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988713007/1
4 years, 7 months ago (2016-05-17 20:32:30 UTC) #9
danakj
On Tue, May 17, 2016 at 1:31 PM, <thakis@chromium.org> wrote: > On 2016/05/17 20:26:25, Robert ...
4 years, 7 months ago (2016-05-17 20:33:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 22:38:00 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 22:39:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e87a03db441fbf78968898ba0078aef67d6b62a8
Cr-Commit-Position: refs/heads/master@{#394248}

Powered by Google App Engine
This is Rietveld 408576698