gn/mac: Build cc_blink_unittests

gn/mac: Build cc_blink_unittests

This seems to Just Work.

BUG=612528
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e87a03db441fbf78968898ba0078aef67d6b62a8
Cr-Commit-Position: refs/heads/master@{#394248}

[Nico, 2016-05-17 20:06:14]

Description was changed from

==========
gn/mac: Build cc_blink_unittests

This seems to Just Work.

BUG=612528
==========

to

==========
gn/mac: Build cc_blink_unittests

This seems to Just Work.

BUG=612528
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Nico, 2016-05-17 20:07:31]

thakis@chromium.org changed reviewers:
+ danakj@chromium.org, rsesek@chromium.org

[Nico, 2016-05-17 20:07:31]

rsesek for gn expertise, danakj for owner stamping

[Robert Sesek, 2016-05-17 20:26:25]

LGTM. Do these run on any bots?

[danakj, 2016-05-17 20:29:42]

LGTM

[danakj, 2016-05-17 20:30:09]

On 2016/05/17 20:26:25, Robert Sesek wrote:
> LGTM. Do these run on any bots?

They should run in the same places as cc_unittests. Double checking that might
be good..

[Nico, 2016-05-17 20:31:25]

On 2016/05/17 20:26:25, Robert Sesek wrote:
> LGTM. Do these run on any bots?

Doesn't look like it:
https://code.google.com/p/chromium/codesearch#search/&q=cc_blink_unittests%20...

The binary also contains a single .cc file
(web_layer_impl_fixed_bounds_unittest.cc) -- Dana, do you know why that file
isn't just part of cc_unittests?

[Nico, 2016-05-17 20:31:29]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988713007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988713007/1

[danakj, 2016-05-17 20:33:49]

On Tue, May 17, 2016 at 1:31 PM, <thakis@chromium.org> wrote:

> On 2016/05/17 20:26:25, Robert Sesek wrote:
> > LGTM. Do these run on any bots?
>
> Doesn't look like it:
>
>
https://code.google.com/p/chromium/codesearch#search/&q=cc_blink_unittests%20...
>
> The binary also contains a single .cc file
> (web_layer_impl_fixed_bounds_unittest.cc) -- Dana, do you know why that
> file
> isn't just part of cc_unittests?
>

cc_blink is a separate component cuz it depends on blink. cc_unittests
don't depend on blink and we don't want them to.

The directory is going to go away eventually, they exist because of
pre-blink-merge but it's hard. I'm surprised there's only one test file
left, but I guess we don't want to pretend it doesn't exist..


>
> https://codereview.chromium.org/1988713007/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-05-17 22:38:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 22:39:10]

Description was changed from

==========
gn/mac: Build cc_blink_unittests

This seems to Just Work.

BUG=612528
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
gn/mac: Build cc_blink_unittests

This seems to Just Work.

BUG=612528
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e87a03db441fbf78968898ba0078aef67d6b62a8
Cr-Commit-Position: refs/heads/master@{#394248}
==========

[commit-bot: I haz the power, 2016-05-17 22:39:11]

Patchset 1 (id:??) landed as
https://crrev.com/e87a03db441fbf78968898ba0078aef67d6b62a8
Cr-Commit-Position: refs/heads/master@{#394248}