Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1988683004: Use _extensionType for detecting prototype inheritance. (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use _extensionType for detecting prototype inheritance. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/e28ee5e914a1dc5ea01eb6d018b94d1ec93bb4ff

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +2 lines, -3 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/classes.dart View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
4 years, 7 months ago (2016-05-17 19:57:12 UTC) #3
Jennifer Messerly
lgtm!
4 years, 7 months ago (2016-05-17 20:44:40 UTC) #4
sra1
4 years, 7 months ago (2016-05-18 18:14:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
e28ee5e914a1dc5ea01eb6d018b94d1ec93bb4ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698