Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1988673002: [js-perf-test] Fix JSTests/PropertyQueries microbenchmark. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-test] Fix JSTests/PropertyQueries microbenchmark. 1) Create fast objects so that they stay fast after creation. 2) Run combination "test_function vs {test_objects}" as a benchmark during 1 second. This CL changes benchmark's base score. Committed: https://crrev.com/2318facdc90b8372a7ec88db15ba4630aa50bc42 Cr-Commit-Position: refs/heads/master@{#36277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M test/js-perf-test/PropertyQueries/property-queries.js View 4 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-17 10:04:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988673002/1
4 years, 7 months ago (2016-05-17 10:04:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 10:30:59 UTC) #6
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-17 11:23:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988673002/1
4 years, 7 months ago (2016-05-17 11:23:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 11:26:30 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 11:28:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2318facdc90b8372a7ec88db15ba4630aa50bc42
Cr-Commit-Position: refs/heads/master@{#36277}

Powered by Google App Engine
This is Rietveld 408576698