Add: check exploded time is properly converted

base/time/time.h

Index: base/time/time.h
diff --git a/base/time/time.h b/base/time/time.h
index 9fce71b581e4ca27c216e31cb40ab78b867760ea..af55ecd7ce0a6fd4d7a5926b69641fcd1fd8d792 100644
--- a/base/time/time.h
+++ b/base/time/time.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[mmenke, 2016/05/18 17:32:00]

You shouldn't update copyright dates when updating files.  We used to do that,
but then the word came not to do it.  I'm not a lawyer, so can't explain why.

This goes for all files.

[maksims (do not use this acc), 2016/05/19 09:57:20]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -420,6 +420,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
     // respective ranges. A 'true' return value does not guarantee the
     // Exploded value can be successfully converted to a Time value.
     bool HasValidValues() const;
+    bool operator!=(const Exploded& rhs);

[eroman, 2016/05/18 19:35:17]

I don't think we want to call this operator!=().

The issue is that with a == or != one expects every field to be compared for
equality.

Whereas for this application, we do *not* want to compare equality of
|day_of_week|, since that is a computed value.

Other naming ideas:

  IsEquivalent()
  Matches()

[Mark Mentovai, 2016/05/18 20:07:15]

I had the same comment as a draft, then I went to recheck what the style guide
said to get a good link to it, and I found that the recommendation has changed.

https://google.github.io/styleguide/cppguide.html#Operator_Overloading

Notably:
So I’m OK with this overload now.

[maksims (do not use this acc), 2016/05/19 09:57:20]

Ok!

   };
 
   // Contains the NULL time. Use Time::Now() to get the current time.