Add: check exploded time is properly converted

base/time/time_unittest.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time/time.h"
 
 #include <stdint.h>
 #include <time.h>
 #include <limits>
 #include <string>
 
@@ skipping 106 matching lines @@
   Time now = Time::NowFromSystemTime();
   Time::Exploded exploded1 = {0};
   now.UTCExplode(&exploded1);
   exploded1.millisecond = 500;
   Time time = Time::FromUTCExploded(exploded1);
   Time::Exploded exploded2 = {0};
   time.UTCExplode(&exploded2);
   EXPECT_EQ(exploded1.millisecond, exploded2.millisecond);
 }
 
+TEST_F(TimeTest, FromExplodedError) {

[mmenke, 2016/05/18 17:32:01]

Maybe call this test "FromExplodedOutOfBoundsTime"?

[maksims (do not use this acc), 2016/05/19 09:57:20]

Done.

+  // FromUTCExploded might return Time(0), if the day is set to 31 on a

[mmenke, 2016/05/18 17:32:01]

nit:  might -> must

[maksims (do not use this acc), 2016/05/19 09:57:20]

Done.

+  // 28-30 day month. Test |exploded| returns Time(0) on 31st of February and
+  // 31st of April;
+  base::Time::Exploded exploded = {0};
+  exploded.year = 2016;
+  exploded.month = 2;
+  exploded.day_of_month = 31;
+  exploded.hour = 12;
+  exploded.minute = 30;
+  exploded.second = 0;
+
+  EXPECT_TRUE(exploded.HasValidValues());
+
+  base::Time t_time = base::Time::FromUTCExploded(exploded);
+  EXPECT_TRUE(t_time.is_null());
+  t_time = base::Time::FromLocalExploded(exploded);
+  EXPECT_TRUE(t_time.is_null());
+
+  // 31st of April
+  exploded.year = 2016;
+  exploded.month = 4;
+  exploded.day_of_month = 31;
+  exploded.hour = 12;
+  exploded.minute = 30;

[eroman, 2016/05/18 19:35:17]

Good start, but will also want tests for:
  * negative months/days/hours/minutes/seconds
   * seconds/minutes/hours/milliseconds that are too large

[maksims (do not use this acc), 2016/05/19 09:57:20]

Done.

+  exploded.second = 0;
+
+  EXPECT_TRUE(exploded.HasValidValues());
+
+  t_time = base::Time::FromUTCExploded(exploded);
+  EXPECT_TRUE(t_time.is_null());
+  t_time = base::Time::FromLocalExploded(exploded);
+  EXPECT_TRUE(t_time.is_null());
+}
+
 TEST_F(TimeTest, ZeroIsSymmetric) {
   Time zero_time(Time::FromTimeT(0));
   EXPECT_EQ(0, zero_time.ToTimeT());
 
   EXPECT_EQ(0.0, zero_time.ToDoubleT());
 }
 
 TEST_F(TimeTest, LocalExplode) {
   Time a = Time::Now();
   Time::Exploded exploded;
@@ skipping 978 matching lines @@
 
 TEST(TimeTicksLogging, DoesNotMakeStreamBad) {
   std::ostringstream oss;
   oss << TimeTicks();
   EXPECT_TRUE(oss.good());
 }
 
 }  // namespace
 
 }  // namespace base