Add: check exploded time is properly converted

base/time/time_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time/time.h"
 
 #include <stdint.h>
 #include <time.h>
 #include <limits>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/platform_thread.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 
 namespace {
 
+const struct DateTestData {
+  Time::Exploded explode;
+  bool is_valid;
+} kDateTestData[] = {
+    // 31st of February
+    {{2016, 2, 0, 31, 12, 30, 0, 0}, true},
+    // 31st of April
+    {{2016, 4, 0, 31, 8, 43, 0, 0}, true},
+    // Negative month
+    {{2016, -5, 0, 2, 4, 10, 0, 0}, false},
+    // Negative date of month
+    {{2016, 6, 0, -15, 2, 50, 0, 0}, false},
+    // Negative hours
+    {{2016, 7, 0, 10, -11, 29, 0, 0}, false},
+    // Negative minutes
+    {{2016, 3, 0, 14, 10, -29, 0, 0}, false},
+    // Negative seconds
+    {{2016, 10, 0, 25, 7, 47, -30, 0}, false},
+    // Negative milliseconds
+    {{2016, 10, 0, 25, 7, 47, 20, -500}, false},
+    // Hours are too large
+    {{2016, 7, 0, 10, 26, 29, 0, 0}, false},
+    // Minutes are too large
+    {{2016, 3, 0, 14, 10, 78, 0, 0}, false},
+    // Seconds are too large
+    {{2016, 10, 0, 25, 7, 47, 234, 0}, false},
+    // Milliseconds are too large
+    {{2016, 10, 0, 25, 6, 31, 23, 1643}, false},
+};
+
+void PrintTo(const DateTestData& test_data, std::ostream* os) {

[mmenke, 2016/05/24 16:08:33]

I don't think this is used?

[maksims (do not use this acc), 2016/05/26 04:38:18]

it is automatically invoked by gtest, when using TestWithParam

+  *os << " year: " << test_data.explode.year
+      << "; month: " << test_data.explode.month
+      << "; day_of_month: " << test_data.explode.day_of_month
+      << "; hour: " << test_data.explode.hour
+      << "; minute: " << test_data.explode.minute
+      << "; second: " << test_data.explode.second
+      << "; millisecond: " << test_data.explode.millisecond;
+}
+
+// Class for testing out of real bounds times.
+// For example, setting day 31 on 30 day month.
+class TimeTestOutOfBounds : public testing::TestWithParam<DateTestData> {
+ public:
+  virtual ~TimeTestOutOfBounds() {}
+  void SetUp() override { test_data_ = GetParam(); }
+
+ protected:
+  DateTestData test_data_;
+};
+
+TEST_P(TimeTestOutOfBounds, FromExplodedOutOfBoundsTime) {
+  // FromUTCExploded must set time to Time(0) and failure, if the day is set to
+  // 31 on a 28-30 day month. Test |exploded| returns Time(0) on 31st of
+  // February and 31st of April. New implementation handles this.
+  EXPECT_EQ(test_data_.explode.HasValidValues(), test_data_.is_valid);
+
+  base::Time result;
+  EXPECT_FALSE(base::Time::FromUTCExploded(test_data_.explode, &result));
+  EXPECT_TRUE(result.is_null());
+  EXPECT_FALSE(base::Time::FromLocalExploded(test_data_.explode, &result));
+  EXPECT_TRUE(result.is_null());
+}
+
+INSTANTIATE_TEST_CASE_P(,
+                        TimeTestOutOfBounds,
+                        testing::ValuesIn(kDateTestData));

[mmenke, 2016/05/24 16:08:33]

Rather than use "INSTANTIATE_TEST_CASE_P", may just want to use a single TEST
with a range-based for loop, like:

TEST(TimeTestOutOfBounds) {
  const struct DateTestData =....

  for (const auto& test : kDateTestData) {
    ...
  }
}

It's my experience that it's simpler to read and debug tests without TEST_P,
when there's less macro magic going on.

[maksims (do not use this acc), 2016/05/26 04:38:18]

Done.

+
 // Specialized test fixture allowing time strings without timezones to be
 // tested by comparing them to a known time in the local zone.
 // See also pr_time_unittests.cc
 class TimeTest : public testing::Test {
  protected:
   void SetUp() override {
     // Use mktime to get a time_t, and turn it into a PRTime by converting
     // seconds to microseconds.  Use 15th Oct 2007 12:45:00 local.  This
     // must be a time guaranteed to be outside of a DST fallback hour in
     // any timezone.
@@ skipping 1087 matching lines @@
 
 TEST(TimeTicksLogging, DoesNotMakeStreamBad) {
   std::ostringstream oss;
   oss << TimeTicks();
   EXPECT_TRUE(oss.good());
 }
 
 }  // namespace
 
 }  // namespace base