Add: check exploded time is properly converted

base/time/time_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time/time.h"
 
 #include <CoreFoundation/CFDate.h>
 #include <CoreFoundation/CFTimeZone.h>
 #include <mach/mach.h>
 #include <mach/mach_time.h>
@@ skipping 166 matching lines @@
       kCFAllocatorDefault, kCFGregorianCalendar));
   CFCalendarSetTimeZone(gregorian, time_zone);
   CFAbsoluteTime absolute_time;
   // 'S' is not defined in componentDesc in Apple documentation, but can be
   // found at http://www.opensource.apple.com/source/CF/CF-855.17/CFCalendar.c
   CFCalendarComposeAbsoluteTime(
       gregorian, &absolute_time, "yMdHmsS", exploded.year, exploded.month,
       exploded.day_of_month, exploded.hour, exploded.minute, exploded.second,
       exploded.millisecond);
   CFAbsoluteTime seconds = absolute_time + kCFAbsoluteTimeIntervalSince1970;
-  return Time(static_cast<int64_t>(seconds * kMicrosecondsPerSecond) +
-              kWindowsEpochDeltaMicroseconds);
+
+  base::Time t_time =

[mmenke, 2016/05/20 19:44:56]

nit:  t_time seems like a weird variable name - it's not clear what the "t_"
means.  I'd suggest just calling it "time".

[maksims (do not use this acc), 2016/05/24 09:14:21]

Done. I already have a "time" in the function arguments.
"out_time" will be a great name, I think.

+        Time(static_cast<int64_t>(seconds * kMicrosecondsPerSecond) +
+             kWindowsEpochDeltaMicroseconds);
+
+  // If |exploded.day_of_month| is set to 31
+  // on a 28-30 day month, it will return the first day of the next month.
+  // Thus round-trip the time and compare the initial |exploded| with
+  // |utc_to_exploded| time.

[mmenke, 2016/05/20 19:44:56]

nit:  Comment can be reformatted - first line of text is unusually short.

[maksims (do not use this acc), 2016/05/24 09:14:21]

Done.

+  base::Time::Exploded to_exploded;
+  if (!is_local)
+    t_time.UTCExplode(&to_exploded);
+  else
+    t_time.LocalExplode(&to_exploded);
+
+  return to_exploded != exploded ? Time(0) : t_time;
+}
+
+// static
+bool Time::FromExploded(bool is_local, const Exploded& exploded, Time& time) {
+  base::ScopedCFTypeRef<CFTimeZoneRef> time_zone(
+      is_local
+          ? CFTimeZoneCopySystem()
+          : CFTimeZoneCreateWithTimeIntervalFromGMT(kCFAllocatorDefault, 0));
+  base::ScopedCFTypeRef<CFCalendarRef> gregorian(CFCalendarCreateWithIdentifier(
+      kCFAllocatorDefault, kCFGregorianCalendar));
+  CFCalendarSetTimeZone(gregorian, time_zone);
+  CFAbsoluteTime absolute_time;
+  // 'S' is not defined in componentDesc in Apple documentation, but can be
+  // found at http://www.opensource.apple.com/source/CF/CF-855.17/CFCalendar.c
+  CFCalendarComposeAbsoluteTime(
+      gregorian, &absolute_time, "yMdHmsS", exploded.year, exploded.month,
+      exploded.day_of_month, exploded.hour, exploded.minute, exploded.second,
+      exploded.millisecond);
+  CFAbsoluteTime seconds = absolute_time + kCFAbsoluteTimeIntervalSince1970;
+
+  base::Time t_time =
+      Time(static_cast<int64_t>(seconds * kMicrosecondsPerSecond) +
+           kWindowsEpochDeltaMicroseconds);
+
+  // If |exploded.day_of_month| is set to 31
+  // on a 28-30 day month, it will return the first day of the next month.
+  // Thus round-trip the time and compare the initial |exploded| with
+  // |utc_to_exploded| time.
+  base::Time::Exploded to_exploded;
+  if (!is_local)
+    t_time.UTCExplode(&to_exploded);
+  else
+    t_time.LocalExplode(&to_exploded);
+
+  time = to_exploded != exploded ? Time(0) : t_time;
+
+  // If time is null, return false
+  // which means time conversion failed
+  return time.is_null() ? false : true;
 }
 
 void Time::Explode(bool is_local, Exploded* exploded) const {
   // Avoid rounding issues, by only putting the integral number of seconds
   // (rounded towards -infinity) into a |CFAbsoluteTime| (which is a |double|).
   int64_t microsecond = us_ % kMicrosecondsPerSecond;
   if (microsecond < 0)
     microsecond += kMicrosecondsPerSecond;
   CFAbsoluteTime seconds = ((us_ - microsecond) / kMicrosecondsPerSecond) -
                            kWindowsEpochDeltaSeconds -
@@ skipping 47 matching lines @@
   return Clock::MAC_MACH_ABSOLUTE_TIME;
 #endif  // defined(OS_IOS)
 }
 
 // static
 ThreadTicks ThreadTicks::Now() {
   return ThreadTicks(ComputeThreadTicks());
 }
 
 }  // namespace base