third_party/WebKit/Source/core/dom/IntersectionObserver.cpp - Issue 1988633002: Schedule a frame from IntersectionObserver::observe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

Issue 1988633002: Schedule a frame from IntersectionObserver::observe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Oilpan doesn't like stack-allocated callback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

index 3aa1f7a61faeb1db5ac1fca3d07815e4beede129..47d0bc30dae330814b1d7176eac6d78dc28c8078 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

@@ -15,6 +15,7 @@

#include "core/dom/IntersectionObserverEntry.h"

#include "core/dom/IntersectionObserverInit.h"

#include "core/dom/NodeIntersectionObserverData.h"

+#include "core/frame/FrameView.h"

#include "core/html/HTMLFrameOwnerElement.h"

#include "core/layout/LayoutView.h"

#include "core/timing/DOMWindowPerformance.h"

@@ -183,6 +184,10 @@ void IntersectionObserver::observe(Element* target)

IntersectionObservation* observation = new IntersectionObservation(*this, *target, shouldReportRootBounds);

target->ensureIntersectionObserverData().addObservation(*observation);

m_observations.add(observation);

+ if (!rootFrame)

+ return;

+ if (FrameView* rootFrameView = rootFrame->view())

+ rootFrameView->scheduleAnimation();

}

void IntersectionObserver::unobserve(Element* target)