Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1988623003: [TurboFan] Fix missing initialization of must_save_lr in OutOfLineRecordWrite. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Fix missing initialization of must_save_lr in OutOfLineRecordWrite. One of the Arm OutOfLineRecordWrite was missing initialiation of must_save_lr Committed: https://crrev.com/b8fe4b0fb4c7930fce67d4b758e71cc285c38be7 Cr-Commit-Position: refs/heads/master@{#36307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rmcilroy
mtrofin - PTAL, thanks. This was the reason for https://codereview.chromium.org/1969423002/ getting reverted for breaking the ...
4 years, 7 months ago (2016-05-17 23:29:20 UTC) #2
Mircea Trofin
On 2016/05/17 23:29:20, rmcilroy wrote: > mtrofin - PTAL, thanks. > > This was the ...
4 years, 7 months ago (2016-05-18 02:46:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988623003/1
4 years, 7 months ago (2016-05-18 06:43:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 07:12:40 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 07:13:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8fe4b0fb4c7930fce67d4b758e71cc285c38be7
Cr-Commit-Position: refs/heads/master@{#36307}

Powered by Google App Engine
This is Rietveld 408576698