src/heap/incremental-marking.cc - Issue 1988623002: Ensure black and gray objects are kept around by scavenger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 1988623002: Ensure black and gray objects are kept around by scavenger (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Cleanup Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index 4c57ecc8332849fdd62834d2ebd7989603db8d2d..f1cc38e00f3f016552b6cb010a7acc820d45a470 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -807,9 +807,9 @@ void IncrementalMarking::UpdateMarkingDequeAfterScavenge() {

new_top = ((new_top + 1) & mask);

DCHECK(new_top != marking_deque->bottom());

#ifdef DEBUG

+ // Mark bit of the source object should be cleared

MarkBit mark_bit = Marking::MarkBitFrom(obj);

- DCHECK(Marking::IsGrey(mark_bit) ||

- (obj->IsFiller() && Marking::IsWhite(mark_bit)));

+ DCHECK(Marking::IsWhite(mark_bit));

#endif

}

} else if (obj->map() != filler_map) {

« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/mark-compact.h » ('j') | no next file with comments »