Eliminate unnecessary covariance checks.

Eliminate unnecessary covariance checks.

This eliminates the erroneous checks inside of nested closures, and
eliminates checks where the type parameter is only used covariantly.

We still don't handle the cases where a generic is implemented by
a non-generic correctly.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/746eabd0d885413560aaa21074b6e0c8645e7a45

[Leaf, 2016-05-17 17:47:32]

leafp@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-05-17 18:09:05]

lgtm

https://codereview.chromium.org/1988613006/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1988613006/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:1677: var parameters = t.parameters.map((p)
=> p.type);
probably a bit faster to merge this with the .any below?

    t.parameters.any((p) => _unsoundCovariant(p.type, !contravariant));

I don't mind either way though :)

[Leaf, 2016-05-17 18:15:36]

https://codereview.chromium.org/1988613006/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1988613006/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:1677: var parameters = t.parameters.map((p)
=> p.type);
On 2016/05/17 18:09:04, John Messerly wrote:
> probably a bit faster to merge this with the .any below?
> 
>     t.parameters.any((p) => _unsoundCovariant(p.type, !contravariant));
> 
> I don't mind either way though :)

Done.

[Leaf, 2016-05-17 19:21:08]

Description was changed from

==========
Eliminate unnecessary covariance checks.

This eliminates the erroneous checks inside of nested closures, and
eliminates checks where the type parameter is only used covariantly.

We still don't handle the cases where a generic is implemented by
a non-generic correctly.

BUG=
==========

to

==========
Eliminate unnecessary covariance checks.

This eliminates the erroneous checks inside of nested closures, and
eliminates checks where the type parameter is only used covariantly.

We still don't handle the cases where a generic is implemented by
a non-generic correctly.

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/746eabd0d885413560aaa21074b6...
==========

[Leaf, 2016-05-17 19:21:09]

Committed patchset #3 (id:40001) manually as
746eabd0d885413560aaa21074b6e0c8645e7a45 (presubmit successful).