content/public/browser/content_browser_client.h - Issue 1988613005: ppapi: PPB_VpnProvider: Implement Service Helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 1988613005: ppapi: PPB_VpnProvider: Implement Service Helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vpn-permission

Patch Set: Refactor patch. Communication now handled using ContentBrowserClient. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/content_browser_client.cc » ('j') | content/public/browser/pepper_vpn_provider_resource_host_proxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index d1f9ae03b71b090d9e6b2909c20b482ed2759526..9ffc0edf0faf3ac6eeee5bc38084683bfc855eef 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -120,6 +120,7 @@ class ServiceRegistry;

class SiteInstance;

class SpeechRecognitionManagerDelegate;

class TracingDelegate;

+class VpnServiceProxy;

class WebContents;

class WebContentsViewDelegate;

struct MainFunctionParams;

@@ -587,6 +588,10 @@ class CONTENT_EXPORT ContentBrowserClient {

virtual bool IsPepperVpnProviderAPIAllowed(BrowserContext* browser_context,

const GURL& url);

+ // Creates a new VpnServiceProxy. The caller owns the returned value. It's

piman 2016/06/16 00:27:09 Please return a std::unique_ptr<VpnServiceProxy> t

adrian.belgun 2016/06/16 12:05:28 Done.

+ // valid to return nullptr.

+ virtual VpnServiceProxy* GetVpnServiceProxy(BrowserContext* browser_context);

// Returns an implementation of a file selecition policy. Can return nullptr.

virtual ui::SelectFilePolicy* CreateSelectFilePolicy(

WebContents* web_contents);