Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1988603003: SDK ext test fix (add missing packages file). (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
A pkg/analyzer_cli/test/data/packages_file/_packages View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/test/sdk_ext_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-17 20:43:40 UTC) #2
Paul Berry
lgtm, thanks! This fixes the regression for me.
4 years, 7 months ago (2016-05-17 20:47:28 UTC) #3
pquitslund
4 years, 7 months ago (2016-05-17 20:49:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
43bbf11dd8ff504c8827a8cdbe6e23d2c075b539 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698