Remove an unnecessary variable from CPDF_Creator

Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.

TBR=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126fb22

[Wei Li, 2016-05-17 07:22:04]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-05-17 07:45:13]

Description was changed from

==========
Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.
==========

to

==========
Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.

TBR=thestig@chromium.org
==========

[Wei Li, 2016-05-17 07:45:21]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-05-17 07:45:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988603002/20001

[commit-bot: I haz the power, 2016-05-17 07:45:47]

Description was changed from

==========
Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.

TBR=thestig@chromium.org
==========

to

==========
Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.

TBR=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126...
==========

[commit-bot: I haz the power, 2016-05-17 07:45:48]

Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126...

[dsinclair, 2016-05-17 13:28:14]

On 2016/05/17 07:45:48, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:20001) as
>
https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126...


I'm not sure if this patch is correct. There is weird ownership of the crypto
handler that isn't very well defined. With this change, I believe it will be
double deleted in certain cases.

By default. the crypto handler is set with m_pParser ?
m_pParser->GetCryptoHandler() : nullptr  (line 885 in the constructor). When
that happens, the actual crypto handler is owned by m_pParser and we should not
free it.

But, if we find a new crypto section during the InitID method we will create a
local crypto parser and set the m_bLocalCryptoHandler flag to true which tells
us we own the handler and should delete it.

So, I think this should be reverted and the flags correctly initialized.

[dsinclair, 2016-05-17 13:28:55]

Description was changed from

==========
Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.

TBR=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126...
==========

to

==========
Remove an unnecessary variable from CPDF_Creator

The variable may not be initialized before using, which caused
errors on DrMemory bot. Since it is not necessary, remove it.

TBR=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126...
==========

[dsinclair, 2016-05-17 13:28:55]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Wei Li, 2016-05-17 16:33:23]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1987783002/ by weili@chromium.org.

The reason for reverting is: The variable is still needed, will fix the other
way..