Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1988583002: Add --extra_patchlevel flag to apply_issue.py (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --extra_patchlevel flag to apply_issue.py This will make it possible to cut away additional levels of directories when applying patches from repos that have a different directory hierarchy than Chromium. BUG=438952 TESTED=Executed successfully in a local checkout using (cwd was the dir above src/): ~/depot_tools/apply_issue.py --root_dir src/third_party/webrtc --issue 1978193002 --server https://codereview.webrtc.org --force --ignore_deps -v -v --no-auth --patchset 20001 --extra_patchlevel=1 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300615

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M apply_issue.py View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_chromium
4 years, 7 months ago (2016-05-17 06:56:18 UTC) #2
tandrii(chromium)
LGTM % nit https://codereview.chromium.org/1988583002/diff/1/apply_issue.py File apply_issue.py (right): https://codereview.chromium.org/1988583002/diff/1/apply_issue.py#newcode98 apply_issue.py:98: 'different directory hierarchys).') nit: s/hierarchys/hierarchies
4 years, 7 months ago (2016-05-17 07:10:38 UTC) #3
kjellander_chromium
https://codereview.chromium.org/1988583002/diff/1/apply_issue.py File apply_issue.py (right): https://codereview.chromium.org/1988583002/diff/1/apply_issue.py#newcode98 apply_issue.py:98: 'different directory hierarchys).') On 2016/05/17 07:10:38, tandrii(chromium)-traveling wrote: > ...
4 years, 7 months ago (2016-05-17 07:12:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988583002/20001
4 years, 7 months ago (2016-05-17 07:12:46 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 07:15:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300615

Powered by Google App Engine
This is Rietveld 408576698