Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1988573003: Remove now-unused kIllegalBytecode bailout reason. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
oth, Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove now-unused kIllegalBytecode bailout reason. R=mstarzinger@chromium.org, oth@chromium.org BUG= Committed: https://crrev.com/b9bfbcb55845b4fa399fafb463e9e8c0650ed18f Cr-Commit-Position: refs/heads/master@{#36281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
4 years, 7 months ago (2016-05-17 11:58:37 UTC) #1
oth
Thanks Georg, lgtm.
4 years, 7 months ago (2016-05-17 12:36:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988573003/1
4 years, 7 months ago (2016-05-17 13:04:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 13:35:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9bfbcb55845b4fa399fafb463e9e8c0650ed18f Cr-Commit-Position: refs/heads/master@{#36281}
4 years, 7 months ago (2016-05-17 13:36:29 UTC) #7
Michael Starzinger
4 years, 7 months ago (2016-05-17 14:53:36 UTC) #8
Message was sent while issue was closed.
There actually is a tool to find those unused bailout reasons. :)

$ ./tools/check-unused-bailouts.sh 
Bailout reason "kArrayBoilerplateCreationFailed" seems to be unused.
Bailout reason "kDefaultNaNModeNotSet" seems to be unused.
Bailout reason "kExpectedAlignmentMarker" seems to be unused.
Bailout reason "kFrameIsExpectedToBeAligned" seems to be unused.
Bailout reason "kInvalidCaptureReferenced" seems to be unused.
Bailout reason "kLiveBytesCountOverflowChunkSize" seems to be unused.
Bailout reason "kOperandIsNotADate" seems to be unused.
Bailout reason "kTheSourceAndDestinationAreTheSame" seems to be unused.
Bailout reason "kUnexpectedNumberOfPreAllocatedPropertyFields" seems to be
unused.
Kthxbye.

Powered by Google App Engine
This is Rietveld 408576698