chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java - Issue 1988553002: Android omnibox: Force paragraph direction to LTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

Issue 1988553002: Android omnibox: Force paragraph direction to LTR. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set alignment correctly, and URLs in SuggestionView match URL bar. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

index c57ff4041508c76aa29100cfbc29742633a80c0f..47d6e7d2b3e2c4db11b959e7975566919cede4cd 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java

@@ -657,15 +657,6 @@ public class OmniboxTest extends ChromeActivityTestCaseBase<ChromeActivity> {

Map<String, List<SuggestionsResult>> suggestionsMap = buildSuggestionMap(

new TestSuggestionResultsBuilder()

- .setTextShownFor("ل")

- .addSuggestions(new SuggestionsResultBuilder()

- .addGeneratedSuggestion(OmniboxSuggestionType.SEARCH_HISTORY,

- "للك", null)

- .addGeneratedSuggestion(OmniboxSuggestionType.SEARCH_HISTORY,

- "www.test.com", null)

- .addGeneratedSuggestion(OmniboxSuggestionType.SEARCH_HISTORY,

- "للكتا", null)),

- new TestSuggestionResultsBuilder()

.setTextShownFor("للك")

.addSuggestions(new SuggestionsResultBuilder()

.addGeneratedSuggestion(OmniboxSuggestionType.SEARCH_HISTORY,

@@ -692,18 +683,11 @@ public class OmniboxTest extends ChromeActivityTestCaseBase<ChromeActivity> {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- urlBarView.setText("ل");

- }

- });

- verifyOmniboxSuggestionAlignment(locationBar, 3, View.LAYOUT_DIRECTION_RTL);

- ThreadUtils.runOnUiThreadBlocking(new Runnable() {

- @Override

- public void run() {

urlBarView.setText("للك");

}

});

- verifyOmniboxSuggestionAlignment(locationBar, 1, View.LAYOUT_DIRECTION_RTL);

+ // Always LTR, even if both the entered text and the suggestions are RTL strings.

+ verifyOmniboxSuggestionAlignment(locationBar, 1, View.LAYOUT_DIRECTION_LTR);

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override