Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 1988553002: Android omnibox: Force paragraph direction to LTR. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set alignment correctly, and URLs in SuggestionView match URL bar. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index 474f62adef05b706d2c3939a87a57443286e1b70..41de929a9733b5ef8c49f614fe25ffc2c7828f7d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -582,16 +582,6 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
getSelectedView().setSelected(true);
}
}
-
- private void updateSuggestionsLayoutDirection(int layoutDirection) {
- if (!isShown()) return;
-
- for (int i = 0; i < getChildCount(); i++) {
- View childView = getChildAt(i);
- if (!(childView instanceof SuggestionView)) continue;
- ApiCompatibilityUtils.setLayoutDirection(childView, layoutDirection);
- }
- }
}
public LocationBarLayout(Context context, AttributeSet attrs) {
@@ -677,19 +667,6 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
mUrlBar.setOnKeyListener(new UrlBarKeyListener());
- // mLocationBar's direction is tied to this UrlBar's text direction. Icons inside the
- // location bar, e.g. lock, refresh, X, should be reversed if UrlBar's text is RTL.
- mUrlBar.setUrlDirectionListener(new UrlBar.UrlDirectionListener() {
- @Override
- public void onUrlDirectionChanged(int layoutDirection) {
- ApiCompatibilityUtils.setLayoutDirection(LocationBarLayout.this, layoutDirection);
-
- if (mSuggestionList != null) {
- mSuggestionList.updateSuggestionsLayoutDirection(layoutDirection);
- }
- }
- });
-
mUrlBar.setSelectAllOnFocus(true);
}

Powered by Google App Engine
This is Rietveld 408576698