test/codegen/expect/8invalid-chars.in+file_name.js - Issue 1988503002: Move generated files to gen/. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(592)

My Issues | Starred Open | Closed | All

Side by Side Diff: test/codegen/expect/8invalid-chars.in+file_name.js

Issue 1988503002: Move generated files to gen/. (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« karma.conf.js ('K') | « test/codegen/corelib/string_operations_with_null_test.dart~ ('k') | test/codegen/expect/8invalid-chars.in+file_name.txt » ('j') | test/codegen_test.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 dart_library.library('8invalid-chars.in+file_name', null, /* Imports */[
Jennifer Messerly 2016/05/17 17:43:52 you can delete the input files for these tests too you can delete the input files for these tests too. There's no point in compiling them if we don't intend to verify the output. Only ones that are worth keeping is the ones that are testing non-standard command line options (like --closure or node-modules), until we can get some other coverage for them. Bob Nystrom 2016/05/18 00:12:58 OK, deleted a bunch more from the top level direct Show quoted text On 2016/05/17 17:43:52, John Messerly wrote: > you can delete the input files for these tests too. There's no point in > compiling them if we don't intend to verify the output. > > Only ones that are worth keeping is the ones that are testing non-standard > command line options (like --closure or node-modules), until we can get some > other coverage for them. OK, deleted a bunch more from the top level directory. Let me know if I was overzealous or missed some. I kept the ones that specified options or looked "important" to me.
2 'dart_sdk'

3 ], function(exports, dart_sdk) {

4 'use strict';

5 const core = dart_sdk.core;

6 const dart = dart_sdk.dart;

7 const dartx = dart_sdk.dartx;

8 const $8invalid$45chars$46in$43file_name = Object.create(null);

9 $8invalid$45chars$46in$43file_name.main = function() {

10 };

11 dart.fn($8invalid$45chars$46in$43file_name.main);

12 // Exports:

13 exports.$8invalid$45chars$46in$43file_name = $8invalid$45chars$46in$43file_nam e;

14 });

OLD	NEW

« karma.conf.js ('K') | « test/codegen/corelib/string_operations_with_null_test.dart~ ('k') | test/codegen/expect/8invalid-chars.in+file_name.txt » ('j') | test/codegen_test.dart » ('J')

Powered by Google App Engine

This is Rietveld 408576698