WebCrypto: Add interfaces for importKey().

Source/modules/crypto/CryptoOperation.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
 class ScriptPromiseResolver;
 
 typedef int ExceptionCode;
 
-class CryptoOperation : public ScriptWrappable, public WebKit::WebCryptoOperationResult, public RefCounted<CryptoOperation> {
+class CryptoOperation : public ScriptWrappable, public RefCounted<CryptoOperation> {
 public:
     ~CryptoOperation();
-    static PassRefPtr<CryptoOperation> create(const WebKit::WebCryptoAlgorithm&, ExceptionCode*);
+    static PassRefPtr<CryptoOperation> create(const WebKit::WebCryptoAlgorithm&);
 
     CryptoOperation* process(ArrayBuffer* data);
     CryptoOperation* process(ArrayBufferView* data);
 
     ScriptObject finish();
     ScriptObject abort();
 
     Algorithm* algorithm();
 
-    // Implementation of WebKit::WebCryptoOperationResult.
-    virtual void initializationFailed() OVERRIDE;
-    virtual void initializationSucceded(WebKit::WebCryptoOperation*) OVERRIDE;
-    virtual void completeWithError() OVERRIDE;
-    virtual void completeWithArrayBuffer(const WebKit::WebArrayBuffer&) OVERRIDE;
+    void initializationFailed();
+    void initializationSucceeded(WebKit::WebCryptoOperation*);
+    void completeWithError();
+    void completeWithArrayBuffer(const WebKit::WebArrayBuffer&);
+
+    CryptoOperation* returnValue(ExceptionCode&);
 
 private:
     enum State {
         // Constructing the WebCryptoOperation.
         Initializing,
 
         // Accepting calls to process().
         Processing,
 
         // finish() has been called, but the Promise has not been resolved yet.
         Finishing,
 
         // The operation either:
         //  - completed successfully
         //  - failed
         //  - was aborted
         Done,
     };
 
-    CryptoOperation(const WebKit::WebCryptoAlgorithm&, ExceptionCode*);
+    CryptoOperation(const WebKit::WebCryptoAlgorithm&);

[abarth-chromium, 2013/07/23 21:45:49]

Please mark one-argument constructors "explicit"

[eroman, 2013/07/23 23:29:02]

Done.

 
     void process(const unsigned char*, size_t);
 
     // Aborts and clears m_impl. If the operation has already comleted then
     // returns false.
     bool abortImpl();
 
     ScriptPromiseResolver* promiseResolver();
 
     WebKit::WebCryptoAlgorithm m_algorithm;
     WebKit::WebCryptoOperation* m_impl;
     RefPtr<Algorithm> m_algorithmNode;
     State m_state;
 
     RefPtr<ScriptPromiseResolver> m_promiseResolver;
 
-    ExceptionCode* m_exceptionCode;
+    ExceptionCode m_exceptionCode;
 };
 
 } // namespace WebCore
 
 #endif