Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1988453002: Remove Release() { delete this; } in data importer/exporter (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove Release() { delete this; } in CFXA_Data{Importer,Exporter} Committed: https://pdfium.googlesource.com/pdfium/+/3857904e520ecb06bad545e4e4bfcf4e60dd1f52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +18 lines, -23 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.h View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-16 22:38:54 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-16 22:49:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988453002/1
4 years, 7 months ago (2016-05-16 23:18:41 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 00:05:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3857904e520ecb06bad545e4e4bfcf4e60dd...

Powered by Google App Engine
This is Rietveld 408576698