Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1988423002: Add PaintOptimizations feature to control subsequence caching and empty phase skipping (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
kinuko, chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, darin-cc_chromium.org, dshwang, jam, kinuko+watch, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PaintOptimizations feature to control subsequence caching and empty phase skipping BUG=612911 Committed: https://crrev.com/825e5fab2485e8e3ea64bf4d957cdd1cd22f9daa Cr-Commit-Position: refs/heads/master@{#394682}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Feature disabled by default, for testing on try bots. #

Patch Set 4 : Original CL for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M content/child/runtime_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Xianzhu
Ptal: kinuko@: content/ chrishtr@: third_party/WebKit
4 years, 7 months ago (2016-05-18 23:01:52 UTC) #2
chrishtr
lgtm Please try a run through the tests with the flag before committing.
4 years, 7 months ago (2016-05-19 00:05:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988423002/40001
4 years, 7 months ago (2016-05-19 00:50:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988423002/40001
4 years, 7 months ago (2016-05-19 00:52:36 UTC) #9
kinuko
lgtm.
4 years, 7 months ago (2016-05-19 01:39:30 UTC) #10
Xianzhu
On 2016/05/19 00:05:13, chrishtr wrote: > lgtm > > Please try a run through the ...
4 years, 7 months ago (2016-05-19 05:05:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988423002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988423002/2
4 years, 7 months ago (2016-05-19 05:05:33 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:2)
4 years, 7 months ago (2016-05-19 05:10:54 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/825e5fab2485e8e3ea64bf4d957cdd1cd22f9daa Cr-Commit-Position: refs/heads/master@{#394682}
4 years, 7 months ago (2016-05-19 05:12:41 UTC) #17
Xianzhu
4 years, 3 months ago (2016-08-29 18:15:33 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:2) has been created in
https://codereview.chromium.org/2289923002/ by wangxianzhu@chromium.org.

The reason for reverting is: We have finished the field trial..

Powered by Google App Engine
This is Rietveld 408576698