Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1988353003:
Add missing test file to tracing:unit_tests (Closed)
|
Created:
4 years, 7 months ago by brucedawson Modified:
4 years, 7 months ago CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd missing test file to tracing:unit_tests
BUG=604060
Committed: https://crrev.com/04e9985e9f96be6776d3afd3b383e8df3f7fe83e
Cr-Commit-Position: refs/heads/master@{#395105}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 22 (9 generated)
brucedawson@chromium.org changed reviewers: + nduca@chromium.org
I'm trying to resolve all test files which are in gyp builds but not gn. PTAL.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988353003/1
primiano@chromium.org changed reviewers: + primiano@chromium.org
LGTM https://codereview.chromium.org/1988353003/diff/1/components/tracing/BUILD.gn File components/tracing/BUILD.gn (right): https://codereview.chromium.org/1988353003/diff/1/components/tracing/BUILD.gn... components/tracing/BUILD.gn:54: "child_trace_message_filter_unittest.cc", FYI in gyp they seem excluded for IOS. But I guess gn for IOS is not a thing yet and somebody else will have to deal with that?
They are also excluded for iOS in gn, but that disabling happens in components\BUILD.gn - see # !iOS around line 163.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988353003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/05/19 17:52:35, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) nduca@ - I guess we still need your approval for this change.
primiano@chromium.org changed reviewers: + oysteine@chromium.org
blah I seem to have no powers in this folder. +oysteine
lgtm
The CQ bit was checked by oysteine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988353003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add missing test file to tracing:unit_tests BUG=604060 ========== to ========== Add missing test file to tracing:unit_tests BUG=604060 Committed: https://crrev.com/04e9985e9f96be6776d3afd3b383e8df3f7fe83e Cr-Commit-Position: refs/heads/master@{#395105} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/04e9985e9f96be6776d3afd3b383e8df3f7fe83e Cr-Commit-Position: refs/heads/master@{#395105} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
