Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 198833002: Make translation of modulus operation '--stress-opt'-proof. (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Make translation of modulus operation '--stress-opt'-proof. Note that we unconditionally deopt later, anyway, but our compilation pipeline has to survive long enough to reach that place. :-/ LOG=y BUG=352059 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19884

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M src/hydrogen.cc View 1 chunk +9 lines, -15 lines 0 comments Download
A + test/mjsunit/regress/regress-352059.js View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sven Panne
6 years, 9 months ago (2014-03-13 09:29:07 UTC) #1
Benedikt Meurer
Please add a regression test.
6 years, 9 months ago (2014-03-13 09:29:41 UTC) #2
Sven Panne
On 2014/03/13 09:29:41, Benedikt Meurer wrote: > Please add a regression test. oops, forgot to ...
6 years, 9 months ago (2014-03-13 09:30:36 UTC) #3
Benedikt Meurer
LGTM
6 years, 9 months ago (2014-03-13 09:31:55 UTC) #4
Sven Panne
6 years, 9 months ago (2014-03-13 09:37:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698