Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1988313004: Test pixel results for repaint tests testing selection, etc. (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test pixel results for repaint tests testing selection, etc. BUG=611462 Committed: https://crrev.com/bf0f6bb237356ecd8170fa639f57ff83b34991b9 Cr-Commit-Position: refs/heads/master@{#395190}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -54 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 3 chunks +44 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/repaint-subrect-grid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/4776765.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/button-checkbox-click-method-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/canvas-putImageData.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/canvas-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/canvas-resize-no-full-invalidation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/caret-invalidation-in-overflow-scroll.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/caret-outside-block.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/caret-with-transformation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/delete-into-nested-block.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/focus-enable-continuations.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/inline-focus.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/inline-outline-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/invalidate-paint-for-fixed-pos-inside-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/japanese-rl-selection-clear.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/japanese-rl-selection-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/no-caret-repaint-in-non-content-editable-element.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/paint-invalidation-with-reparent-across-frame-boundaries.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/repaint-across-writing-mode-boundary.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selected-replaced.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-after-delete.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-after-remove.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-change-in-iframe-with-relative-parent.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-clear.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-clear-after-move.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-partial-invalidation-between-blocks.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/selection-rl.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/subtree-root-skipped.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/text-selection-rect-in-overflow-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-for-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-for-vertical-lr.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-for-vertical-rl.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Xianzhu
4 years, 7 months ago (2016-05-20 16:17:15 UTC) #2
chrishtr
Please first check on the impact on the CQ of the previous CL in practice. ...
4 years, 7 months ago (2016-05-20 18:19:39 UTC) #3
Xianzhu
On 2016/05/20 18:19:39, chrishtr wrote: > Please first check on the impact on the CQ ...
4 years, 7 months ago (2016-05-20 18:58:19 UTC) #4
chrishtr
lgtm
4 years, 7 months ago (2016-05-20 19:06:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988313004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988313004/40001
4 years, 7 months ago (2016-05-20 19:06:57 UTC) #7
Xianzhu
On 2016/05/20 19:06:57, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-20 19:09:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988313004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988313004/60001
4 years, 7 months ago (2016-05-20 19:17:42 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-20 22:33:12 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 22:34:50 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bf0f6bb237356ecd8170fa639f57ff83b34991b9
Cr-Commit-Position: refs/heads/master@{#395190}

Powered by Google App Engine
This is Rietveld 408576698