Suppress frame URL query failures

Suppress frame URL query failures

Before this CL, firstPaintMetric raised exception and stopped processing
when it failed to find URL for a particular frame.
This CL makes the firstPaintMetric to silently ignore the frame, and
continue processing for other frames.

BUG=chromium:613050
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2afd12a46d185e3988b45aee2a258030b0e3611a

[kouhei (in TOK), 2016-05-19 05:45:15]

kouhei@chromium.org changed reviewers:
+ eakuefner@chromium.org, nednguyen@google.com

[nednguyen(REVIEW IN OTHER ACC), 2016-05-19 12:57:48]

nednguyen@chromium.org changed reviewers:
+ nednguyen@chromium.org

[nednguyen(REVIEW IN OTHER ACC), 2016-05-19 12:57:48]

Add logging.error?

[nednguyen(REVIEW IN OTHER ACC), 2016-05-19 12:58:48]

Though can yoy explain why it's ok to ignore this failure?

[kouhei (in TOK), 2016-05-19 23:16:03]

On 2016/05/19 12:57:48, nednguyen(REVIEW IN OTHER ACC) wrote:
> Add logging.error?
I couldn't find logging.error. I'm not sure if model.importWarning is
appropriate here.

> Though can yoy explain why it's ok to ignore this failure?
Incomplete traces or traces from old Chrome before FrameLoader object dumps will
fail to compute this metric.
This CL will make those navs not emit values, instead of giving up the whole
trace.

[nednguyen, 2016-05-19 23:20:47]

On 2016/05/19 23:16:03, kouhei wrote:
> On 2016/05/19 12:57:48, nednguyen(REVIEW IN OTHER ACC) wrote:
> > Add logging.error?
> I couldn't find logging.error. I'm not sure if model.importWarning is
> appropriate here.
> 
> > Though can yoy explain why it's ok to ignore this failure?
> Incomplete traces or traces from old Chrome before FrameLoader object dumps
will
> fail to compute this metric.
> This CL will make those navs not emit values, instead of giving up the whole
> trace.

I see. What I meant was console.warn(...). You can make the warning message says
that "Fails to find frame loader in the trace, the trace maybe incomplete or
from an old Chrome."

[kouhei (in TOK), 2016-05-19 23:44:25]

On 2016/05/19 23:20:47, nednguyen wrote:
> On 2016/05/19 23:16:03, kouhei wrote:
> > On 2016/05/19 12:57:48, nednguyen(REVIEW IN OTHER ACC) wrote:
> > > Add logging.error?
> > I couldn't find logging.error. I'm not sure if model.importWarning is
> > appropriate here.
> > 
> > > Though can yoy explain why it's ok to ignore this failure?
> > Incomplete traces or traces from old Chrome before FrameLoader object dumps
> will
> > fail to compute this metric.
> > This CL will make those navs not emit values, instead of giving up the whole
> > trace.
> 
> I see. What I meant was console.warn(...). You can make the warning message
says
> that "Fails to find frame loader in the trace, the trace maybe incomplete or
> from an old Chrome."

Done.

[nednguyen, 2016-05-20 02:08:45]

lgtm

[nednguyen, 2016-05-20 02:08:52]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-05-20 02:08:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988313003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988313003/20001

[commit-bot: I haz the power, 2016-05-20 02:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 02:27:50]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[nednguyen, 2016-05-20 02:36:29]

Description was changed from

==========
Suppress frame URL query failures

Before this CL, firstPaintMetric raised exception and stopped processing
when it failed to find URL for a particular frame.
This CL makes the firstPaintMetric to silently ignore the frame, and
continue processing for other frames.

BUG=613050
==========

to

==========
Suppress frame URL query failures

Before this CL, firstPaintMetric raised exception and stopped processing
when it failed to find URL for a particular frame.
This CL makes the firstPaintMetric to silently ignore the frame, and
continue processing for other frames.

BUG=chromium:613050
==========

[nednguyen, 2016-05-20 02:36:34]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-05-20 02:36:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988313003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988313003/20001

[commit-bot: I haz the power, 2016-05-20 03:17:11]

Description was changed from

==========
Suppress frame URL query failures

Before this CL, firstPaintMetric raised exception and stopped processing
when it failed to find URL for a particular frame.
This CL makes the firstPaintMetric to silently ignore the frame, and
continue processing for other frames.

BUG=chromium:613050
==========

to

==========
Suppress frame URL query failures

Before this CL, firstPaintMetric raised exception and stopped processing
when it failed to find URL for a particular frame.
This CL makes the firstPaintMetric to silently ignore the frame, and
continue processing for other frames.

BUG=chromium:613050

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-05-20 03:17:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...