Expose a way to set a view's base background color.

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 409 matching lines @@
 #if ENABLE(NAVIGATOR_CONTENT_UTILS)
     , m_navigatorContentUtilsClient(NavigatorContentUtilsClientImpl::create(this))
 #endif
     , m_flingModifier(0)
     , m_flingSourceDevice(false)
     , m_showFPSCounter(false)
     , m_showPaintRects(false)
     , m_showDebugBorders(false)
     , m_continuousPaintingEnabled(false)
     , m_showScrollBottleneckRects(false)
+    , m_baseBackgroundColor(Color::white)
 {
     Page::PageClients pageClients;
     pageClients.chromeClient = &m_chromeClientImpl;
     pageClients.contextMenuClient = &m_contextMenuClientImpl;
     pageClients.editorClient = &m_editorClientImpl;
     pageClients.dragClient = &m_dragClientImpl;
     pageClients.inspectorClient = &m_inspectorClientImpl;
     pageClients.backForwardClient = &m_backForwardClientImpl;
 
     m_page = adoptPtr(new Page(pageClients));
@@ skipping 2014 matching lines @@
     if (!frame)
         return false;
     return frame->selection()->isContentEditable();
 }
 
 WebColor WebViewImpl::backgroundColor() const
 {
     if (isTransparent())
         return Color::transparent;
     if (!m_page)
-        return Color::white;
+        return m_baseBackgroundColor;
     FrameView* view = m_page->mainFrame()->view();
     StyleColor backgroundColor = view->documentBackgroundColor();
     if (!backgroundColor.isValid())
-        return Color::white;
+        return m_baseBackgroundColor;
     return backgroundColor.rgb();
 }
 
 bool WebViewImpl::caretOrSelectionRange(size_t* location, size_t* length)
 {
     const Frame* focused = focusedWebCoreFrame();
     if (!focused)
         return false;
 
     FrameSelection* selection = focused->selection();
@@ skipping 1092 matching lines @@
 
     // Future frames check this to know whether to be transparent.
     m_isTransparent = isTransparent;
 }
 
 bool WebViewImpl::isTransparent() const
 {
     return m_isTransparent;
 }
 
+void WebViewImpl::setBaseBackgroundColor(WebColor color)
+{
+    if (m_baseBackgroundColor == color)
+        return;
+
+    m_baseBackgroundColor = color;
+
+    m_page->mainFrame()->view()->updateBackgroundRecursively(color, m_isTransparent);

[jamesr, 2013/07/25 00:02:28]

hmm, why recursive? won't this only change the background color on the root
frameview?

[jamesr, 2013/07/25 00:16:06]

I'm pretty sure calling FrameView::setBaseBackgroundColor() is the right thing
to do. it already has logic to call
renderView()->layer()->backing()->updateContentsOpaque(), so you don't have to
add that other call.

[joth, 2013/07/25 00:39:43]

Done.

(just to clarify: I am relying on the existing updateContentsOpaque() either way
: I haven't added any new call to it just rearranged it to use the already
null-checked 'backing' local)

+
+    if (m_layerTreeView)
+        m_layerTreeView->setBackgroundColor(backgroundColor());
+}
+
 void WebViewImpl::setIsActive(bool active)
 {
     if (page() && page()->focusController())
         page()->focusController()->setActive(active);
 }
 
 bool WebViewImpl::isActive() const
 {
     return (page() && page()->focusController()) ? page()->focusController()->isActive() : false;
 }
@@ skipping 553 matching lines @@
 }
 
 bool WebViewImpl::shouldDisableDesktopWorkarounds()
 {
     ViewportArguments arguments = mainFrameImpl()->frame()->document()->viewportArguments();
     return arguments.width == ViewportArguments::ValueDeviceWidth || !arguments.userZoom
         || (arguments.minZoom == arguments.maxZoom && arguments.minZoom != ViewportArguments::ValueAuto);
 }
 
 } // namespace WebKit