Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1988293003: cc : Delete code not used outside tests related to impl-only animations (Closed)

Created:
4 years, 7 months ago by jaydasika
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Delete code not used outside tests related to impl-only animations This is a follow-up to crrev.com/1981283005. It deletes code in cc/animation for impl-only animations of opacity, transform and filter as we don't support impl-only animations for these properties. BUG=609205 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6b6ee83e652f8f148c48ad1fb210b5b07e919a37 Cr-Commit-Position: refs/heads/master@{#394926}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -257 lines) Patch
M cc/animation/animation_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/animation/animation_host.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M cc/animation/element_animations.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/element_animations.cc View 1 2 3 chunks +2 lines, -69 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 2 3 4 chunks +14 lines, -153 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jaydasika
PTAL
4 years, 7 months ago (2016-05-19 01:18:43 UTC) #3
ajuma
lgtm https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animations.cc File cc/animation/element_animations.cc (right): https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animations.cc#newcode148 cc/animation/element_animations.cc:148: void ElementAnimations::AddAnimation(std::unique_ptr<Animation> animation) { Please add: DCHECK(!animation->is_impl_only() || ...
4 years, 7 months ago (2016-05-19 15:00:57 UTC) #4
jaydasika
Modified one more unittest. https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animations.cc File cc/animation/element_animations.cc (right): https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animations.cc#newcode148 cc/animation/element_animations.cc:148: void ElementAnimations::AddAnimation(std::unique_ptr<Animation> animation) { On ...
4 years, 7 months ago (2016-05-19 20:14:13 UTC) #5
ajuma
Still lgtm https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_animations_unittest.cc File cc/animation/element_animations_unittest.cc (right): https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_animations_unittest.cc#newcode1094 cc/animation/element_animations_unittest.cc:1094: double duration_in_seconds = curve->Duration().InSecondsF(); Can we make ...
4 years, 7 months ago (2016-05-19 20:56:48 UTC) #6
jaydasika
https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_animations_unittest.cc File cc/animation/element_animations_unittest.cc (right): https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_animations_unittest.cc#newcode1094 cc/animation/element_animations_unittest.cc:1094: double duration_in_seconds = curve->Duration().InSecondsF(); On 2016/05/19 20:56:47, ajuma wrote: ...
4 years, 7 months ago (2016-05-19 22:30:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988293003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988293003/60001
4 years, 7 months ago (2016-05-19 22:32:05 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-20 00:30:30 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:32:29 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b6ee83e652f8f148c48ad1fb210b5b07e919a37
Cr-Commit-Position: refs/heads/master@{#394926}

Powered by Google App Engine
This is Rietveld 408576698