cc : Delete code not used outside tests related to impl-only animations

cc : Delete code not used outside tests related to impl-only animations

This is a follow-up to crrev.com/1981283005. It deletes code in
cc/animation for impl-only animations of opacity, transform and filter
as we don't support impl-only animations for these properties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6b6ee83e652f8f148c48ad1fb210b5b07e919a37
Cr-Commit-Position: refs/heads/master@{#394926}

[jaydasika, 2016-05-19 01:17:01]

Description was changed from

==========
cc : Delete code not used outside tests related to impl-only animations

This is a follow-up to crrev.com/1981283005. It deletes code in
cc/animation for impl-only animations of opacity, transform and filter
as we don't support impl-only animations for these properties.

BUG=609205
==========

to

==========
cc : Delete code not used outside tests related to impl-only animations

This is a follow-up to crrev.com/1981283005. It deletes code in
cc/animation for impl-only animations of opacity, transform and filter
as we don't support impl-only animations for these properties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-05-19 01:18:42]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-05-19 01:18:43]

PTAL

[ajuma, 2016-05-19 15:00:57]

lgtm

https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animat...
File cc/animation/element_animations.cc (right):

https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animat...
cc/animation/element_animations.cc:148: void
ElementAnimations::AddAnimation(std::unique_ptr<Animation> animation) {
Please add:
DCHECK(!animation->is_impl_only() || animation->target_property() ==
TargetProperty::SCROLL_OFFSET);

[jaydasika, 2016-05-19 20:14:13]

Modified one more unittest.

https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animat...
File cc/animation/element_animations.cc (right):

https://codereview.chromium.org/1988293003/diff/1/cc/animation/element_animat...
cc/animation/element_animations.cc:148: void
ElementAnimations::AddAnimation(std::unique_ptr<Animation> animation) {
On 2016/05/19 15:00:57, ajuma wrote:
> Please add:
> DCHECK(!animation->is_impl_only() || animation->target_property() ==
> TargetProperty::SCROLL_OFFSET);

Done.

[ajuma, 2016-05-19 20:56:48]

Still lgtm

https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_an...
File cc/animation/element_animations_unittest.cc (right):

https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_an...
cc/animation/element_animations_unittest.cc:1094: double duration_in_seconds =
curve->Duration().InSecondsF();
Can we make this a TimeDelta instead (set to curve->Duration()), and then avoid
the conversion from seconds to TimeDelta below?

[jaydasika, 2016-05-19 22:30:52]

https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_an...
File cc/animation/element_animations_unittest.cc (right):

https://codereview.chromium.org/1988293003/diff/20001/cc/animation/element_an...
cc/animation/element_animations_unittest.cc:1094: double duration_in_seconds =
curve->Duration().InSecondsF();
On 2016/05/19 20:56:47, ajuma wrote:
> Can we make this a TimeDelta instead (set to curve->Duration()), and then
avoid
> the conversion from seconds to TimeDelta below?

Done.

[jaydasika, 2016-05-19 22:30:57]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-05-19 22:30:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1988293003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 22:32:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988293003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988293003/60001

[commit-bot: I haz the power, 2016-05-20 00:30:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-20 00:32:28]

Description was changed from

==========
cc : Delete code not used outside tests related to impl-only animations

This is a follow-up to crrev.com/1981283005. It deletes code in
cc/animation for impl-only animations of opacity, transform and filter
as we don't support impl-only animations for these properties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Delete code not used outside tests related to impl-only animations

This is a follow-up to crrev.com/1981283005. It deletes code in
cc/animation for impl-only animations of opacity, transform and filter
as we don't support impl-only animations for these properties.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6b6ee83e652f8f148c48ad1fb210b5b07e919a37
Cr-Commit-Position: refs/heads/master@{#394926}
==========

[commit-bot: I haz the power, 2016-05-20 00:32:29]

Patchset 4 (id:??) landed as
https://crrev.com/6b6ee83e652f8f148c48ad1fb210b5b07e919a37
Cr-Commit-Position: refs/heads/master@{#394926}