Implement and test aura::client::CaptureClient in views::NativeWidgetMus for plumbing (Set|Release)…

Implement and test aura::client::CaptureClient in views::NativeWidgetMus for plumbing (Set|Release)Capture to mus::Window

R=sadrul@chromium.org
BUG=609555
Committed: https://crrev.com/54051104f41373b093d477c9613fb2768ad2e8e6
Cr-Commit-Position: refs/heads/master@{#395644}

[Mark Dittmer, 2016-05-18 19:57:14]

rebase

[Mark Dittmer, 2016-05-18 20:19:31]

rebase

[Mark Dittmer, 2016-05-18 20:50:08]

rebase

[Mark Dittmer, 2016-05-20 14:32:38]

rebase

[sadrul, 2016-05-24 15:25:19]

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:441: class NativeWidgetMus::MusCaptureClient :
public aura::client::CaptureClient {
This could subclass DefaultCaptureClient instead, and override the bits it needs
to, instead of overriding everything, right?

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:451: void SetCapture(aura::Window* window)
override {
// aura::client::CaptureClient:

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:473:
std::unique_ptr<aura::client::DefaultCaptureClient> delegate_;
DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus_unittest.cc (right):

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus_unittest.cc:457:
EXPECT_FALSE(mus_window->HasCapture());
Hm, because the mus WS is launched just once for all of the tests, it is
possible that this capture request can a failure in some other test. Keep an eye
on this test being flaky, or other capture-related test being flaky. If that
starts happening, then this should move into interactive-ui-test.

[Mark Dittmer, 2016-05-24 16:05:24]

Use inheritance for MusCaptureClient

[Mark Dittmer, 2016-05-24 16:06:21]

Addressed outstanding comments. sadrul@ PTAL.

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:441: class NativeWidgetMus::MusCaptureClient :
public aura::client::CaptureClient {
On 2016/05/24 15:25:19, sadrul wrote:
> This could subclass DefaultCaptureClient instead, and override the bits it
needs
> to, instead of overriding everything, right?

Should work.

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:451: void SetCapture(aura::Window* window)
override {
On 2016/05/24 15:25:19, sadrul wrote:
> // aura::client::CaptureClient:

Done (against aura::client::DefaultCaptureClient).

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:473:
std::unique_ptr<aura::client::DefaultCaptureClient> delegate_;
On 2016/05/24 15:25:19, sadrul wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus_unittest.cc (right):

https://codereview.chromium.org/1988283002/diff/80001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus_unittest.cc:457:
EXPECT_FALSE(mus_window->HasCapture());
On 2016/05/24 15:25:19, sadrul wrote:
> Hm, because the mus WS is launched just once for all of the tests, it is
> possible that this capture request can a failure in some other test. Keep an
eye
> on this test being flaky, or other capture-related test being flaky. If that
> starts happening, then this should move into interactive-ui-test.

Alright. I'll see how the bots feel about this when it lands.

[sadrul, 2016-05-24 16:09:10]

lgtm

[Mark Dittmer, 2016-05-24 16:32:31]

The CQ bit was checked by markdittmer@chromium.org

[commit-bot: I haz the power, 2016-05-24 16:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988283002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988283002/100001

[commit-bot: I haz the power, 2016-05-24 18:29:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-24 18:30:34]

Description was changed from

==========
Implement and test aura::client::CaptureClient in views::NativeWidgetMus for
plumbing (Set|Release)Capture to mus::Window

R=sadrul@chromium.org
BUG=609555
==========

to

==========
Implement and test aura::client::CaptureClient in views::NativeWidgetMus for
plumbing (Set|Release)Capture to mus::Window

R=sadrul@chromium.org
BUG=609555

Committed: https://crrev.com/54051104f41373b093d477c9613fb2768ad2e8e6
Cr-Commit-Position: refs/heads/master@{#395644}
==========

[commit-bot: I haz the power, 2016-05-24 18:30:35]

Patchset 6 (id:??) landed as
https://crrev.com/54051104f41373b093d477c9613fb2768ad2e8e6
Cr-Commit-Position: refs/heads/master@{#395644}