Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3516)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm

Issue 1988223002: [Mac][Material Design] Bring bookmark hover background up to spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
index 4173844ac0ada3f1acf49a43cc1bad4019d47ec1..d83d85f93472c36b44a9e72c3626a7cca05b329f 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
@@ -12,6 +12,7 @@
#include "components/bookmarks/browser/bookmark_model.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
+#include "ui/base/material_design/material_design_controller.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/image/image.h"
#include "ui/resources/grit/ui_resources.h"
@@ -201,7 +202,11 @@ TEST_F(BookmarkButtonCellTest, VerticalTextOffset) {
ASSERT_TRUE(bookmark_cell.get());
EXPECT_EQ(1, [gradient_cell verticalTextOffset]);
- EXPECT_EQ(0, [bookmark_cell verticalTextOffset]);
+ if (ui::MaterialDesignController::IsModeMaterial()) {
+ EXPECT_EQ(-1, [bookmark_cell verticalTextOffset]);
+ } else {
+ EXPECT_EQ(0, [bookmark_cell verticalTextOffset]);
+ }
EXPECT_NE([bookmark_cell verticalTextOffset],
[gradient_cell verticalTextOffset]);
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698