Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1988213003: Check in a lockfile. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check in a lockfile. This should ensure we all use the same versions of dev_compiler's deps when we hack on it. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/7a060c744c6038389db454ded7b52d5f0227e262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -5 lines) Patch
M .gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
A pubspec.lock View 1 chunk +292 lines, -0 lines 0 comments Download
A test/transformer/hello_app/pubspec.lock View 1 chunk +226 lines, -0 lines 0 comments Download
M tool/patch_sdk.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-18 23:30:50 UTC) #2
Jennifer Messerly
lgtm
4 years, 7 months ago (2016-05-18 23:50:35 UTC) #3
Bob Nystrom
4 years, 7 months ago (2016-05-18 23:51:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a060c744c6038389db454ded7b52d5f0227e262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698