Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1988133004: [arm] Remove CpuFeature::MLS. (Closed)

Created:
4 years, 7 months ago by jbramley
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Remove CpuFeature::MLS. The MLS instruction is available in all ARMv7 devices, and in no ARMv6 devices, aside from the usual ARMv6T2 caveat. We don't need a separate feature flag for it. BUG= Committed: https://crrev.com/feeaac4061aae38835c02fe15c48877f9bad379b Cr-Commit-Position: refs/heads/master@{#36378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M src/arm/assembler-arm.cc View 6 chunks +4 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 7 months ago (2016-05-19 16:42:13 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-19 17:23:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988133004/1
4 years, 7 months ago (2016-05-19 17:28:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 18:03:15 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:04:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/feeaac4061aae38835c02fe15c48877f9bad379b
Cr-Commit-Position: refs/heads/master@{#36378}

Powered by Google App Engine
This is Rietveld 408576698