Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 1988133003: Pass command line options of tests to precompiled runtime correctly. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index e9126f8b206fbc75a8b7485a8dd582e3f0deeb00..e9fed49b077cde5ea16598a2fcf9dcd1eb88d0a4 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -348,10 +348,12 @@ class VmCommand extends ProcessCommand {
class AdbPrecompilationCommand extends Command {
final String precompiledRunnerFilename;
final String precompiledTestDirectory;
+ final List<String> arguments;
final bool useBlobs;
AdbPrecompilationCommand._(this.precompiledRunnerFilename,
this.precompiledTestDirectory,
+ this.arguments,
this.useBlobs)
: super._("adb_precompilation");
@@ -359,6 +361,7 @@ class AdbPrecompilationCommand extends Command {
super._buildHashCode(builder);
builder.add(precompiledRunnerFilename);
builder.add(precompiledTestDirectory);
+ builder.add(arguments);
builder.add(useBlobs);
}
@@ -366,6 +369,7 @@ class AdbPrecompilationCommand extends Command {
super._equal(other) &&
precompiledRunnerFilename == other.precompiledRunnerFilename &&
useBlobs == other.useBlobs &&
+ arguments == other.arguments &&
precompiledTestDirectory == other.precompiledTestDirectory;
String toString() => 'Steps to push precompiled runner and precompiled code '
@@ -640,9 +644,10 @@ class CommandBuilder {
AdbPrecompilationCommand getAdbPrecompiledCommand(String precompiledRunner,
String testDirectory,
+ List<String> arguments,
bool useBlobs) {
var command = new AdbPrecompilationCommand._(
- precompiledRunner, testDirectory, useBlobs);
+ precompiledRunner, testDirectory, arguments, useBlobs);
return _getUniqueCommand(command);
}
@@ -2518,6 +2523,7 @@ class CommandExecutorImpl implements CommandExecutor {
AdbDevice device, AdbPrecompilationCommand command, int timeout) async {
var runner = command.precompiledRunnerFilename;
var testdir = command.precompiledTestDirectory;
+ var arguments = command.arguments;
var devicedir = '/data/local/tmp/precompilation-testing';
var deviceTestDir = '/data/local/tmp/precompilation-testing/test';
@@ -2556,13 +2562,13 @@ class CommandExecutorImpl implements CommandExecutor {
steps.add(() => device.runAdbShellCommand(
['$devicedir/dart_precompiled_runtime',
'--run-app-snapshot=$deviceTestDir',
- '--use-blobs', 'ignored.dart'],
+ '--use-blobs']..addAll(arguments),
timeout: timeoutDuration));
} else {
steps.add(() => device.runAdbShellCommand(
['$devicedir/dart_precompiled_runtime',
- '--run-app-snapshot=$deviceTestDir',
- 'ignored.dart'],
+ '--run-app-snapshot=$deviceTestDir'
+ ]..addAll(arguments),
timeout: timeoutDuration));
}
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698