Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: tools/testing/dart/runtime_configuration.dart

Issue 1988133003: Pass command line options of tests to precompiled runtime correctly. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library runtime_configuration; 5 library runtime_configuration;
6 6
7 import 'compiler_configuration.dart' show CommandArtifact; 7 import 'compiler_configuration.dart' show CommandArtifact;
8 8
9 // TODO(ahe): Remove this import, we can precompute all the values required 9 // TODO(ahe): Remove this import, we can precompute all the values required
10 // from TestSuite once the refactoring is complete. 10 // from TestSuite once the refactoring is complete.
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 String script = artifact.filename; 292 String script = artifact.filename;
293 String type = artifact.mimeType; 293 String type = artifact.mimeType;
294 if (script != null && type != 'application/dart-precompiled') { 294 if (script != null && type != 'application/dart-precompiled') {
295 throw "dart_precompiled cannot run files of type '$type'."; 295 throw "dart_precompiled cannot run files of type '$type'.";
296 } 296 }
297 297
298 String precompiledRunner = suite.dartPrecompiledBinaryFileName; 298 String precompiledRunner = suite.dartPrecompiledBinaryFileName;
299 return <Command>[ 299 return <Command>[
300 commandBuilder.getAdbPrecompiledCommand(precompiledRunner, 300 commandBuilder.getAdbPrecompiledCommand(precompiledRunner,
301 script, 301 script,
302 arguments,
302 useBlobs) 303 useBlobs)
303 ]; 304 ];
304 } 305 }
305 } 306 }
306 307
307 /// Temporary runtime configuration for browser runtimes that haven't been 308 /// Temporary runtime configuration for browser runtimes that haven't been
308 /// migrated yet. 309 /// migrated yet.
309 // TODO(ahe): Remove this class. 310 // TODO(ahe): Remove this class.
310 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration { 311 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
311 List<Command> computeRuntimeCommands( 312 List<Command> computeRuntimeCommands(
312 TestSuite suite, 313 TestSuite suite,
313 CommandBuilder commandBuilder, 314 CommandBuilder commandBuilder,
314 CommandArtifact artifact, 315 CommandArtifact artifact,
315 List<String> arguments, 316 List<String> arguments,
316 Map<String, String> environmentOverrides) { 317 Map<String, String> environmentOverrides) {
317 throw "Unimplemented runtime '$runtimeType'"; 318 throw "Unimplemented runtime '$runtimeType'";
318 } 319 }
319 } 320 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698