Issue 1988133003: Pass command line options of tests to precompiled runtime correctly.

Issue 1988133003: Pass command line options of tests to precompiled runtime correctly. (Closed)

Created:
4 years, 7 months ago by Florian Schneider

Modified:
4 years, 7 months ago

Reviewers:
rmacnak, kustermann

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Pass command line options of tests to precompiled runtime correctly. This fixes the precompilation tests on Android that have command line options specified in their test files. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/6c778cab08e687bfdb1606a73f96c4689715555a

Total comments: 2

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	tools/testing/dart/runtime_configuration.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tools/testing/dart/test_runner.dart	View	1	6 chunks	+10 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

kustermann

LGTM So just to be clear: We are now passing the same arguments we normally ...

4 years, 7 months ago (2016-05-18 18:41:15 UTC) #3

Florian Schneider

Yes, there are flags that affect both, compiler and runtime. Flags that only affect the ...

4 years, 7 months ago (2016-05-18 18:55:32 UTC) #4

Florian Schneider

4 years, 7 months ago (2016-05-18 19:00:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6c778cab08e687bfdb1606a73f96c4689715555a (presubmit successful).