Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 1988113004: Clear the login webview when SAML flow is canceled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reset SAML webview with 'about:blank'. Reset when network is disconnected. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js
diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
index 4abf255e226e5ad08acc32f6e7a75d63650396d0..0b307a319e78320cea599d122a89a876f94a6c89 100644
--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
@@ -593,10 +593,12 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
break;
case ScreenMode.OFFLINE:
+ this.gaiaAuthHost_.resetStates();
emaxx 2016/05/23 15:00:49 This (plus the new line 601) resolves the issue th
this.loadOffline(params);
break;
case ScreenMode.SAML_INTERSTITIAL:
+ this.gaiaAuthHost_.resetStates();
$('saml-interstitial').domain = data.enterpriseDomain;
if (this.loading)
this.loading = false;
@@ -923,7 +925,7 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
*/
reset: function(takeFocus, forceOnline) {
// Reload and show the sign-in UI if needed.
- this.gaiaAuthHost_.resetStates_();
+ this.gaiaAuthHost_.resetStates();
if (takeFocus) {
if (!forceOnline && this.isOffline()) {
// Show 'Cancel' button to allow user to return to the main screen

Powered by Google App Engine
This is Rietveld 408576698