Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 1988113004: Clear the login webview when SAML flow is canceled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js
diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
index 4abf255e226e5ad08acc32f6e7a75d63650396d0..10aa3b9a5a1ac22bc4162035732c4b0fec85dbbc 100644
--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
@@ -923,7 +923,7 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
*/
reset: function(takeFocus, forceOnline) {
// Reload and show the sign-in UI if needed.
- this.gaiaAuthHost_.resetStates_();
+ this.gaiaAuthHost_.reload();
emaxx 2016/05/19 19:02:16 Authenticator.prototype.reload does the same as Au
xiyuan 2016/05/19 22:47:08 We have a policy to make Gaia auto redirect to sam
afakhry 2016/05/20 00:14:21 Authenticator.prototype.reload() doesn't reset the
emaxx 2016/05/23 15:00:48 OK, restored this back to calling resetStates_. An
if (takeFocus) {
if (!forceOnline && this.isOffline()) {
// Show 'Cancel' button to allow user to return to the main screen
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698