Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1988073003: Fix Intl*parsing test (Closed)

Created:
4 years, 7 months ago by jungshik at Google
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Intl*parsing tests and test status intl/number-format/parse-percent.js intl/date-format/parse-mdyhms.js intl/number-format/parse-decimal.js intl/date-format/parse-MMMdy.js Also added a few more test cases. BUG=v8:3454 TEST=The tests listed above. Committed: https://crrev.com/72d86e377245f2c91c59294d4f84092810154ae2 Cr-Commit-Position: refs/heads/master@{#36555}

Patch Set 1 #

Patch Set 2 : add // Flags: --intl-extra #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M test/intl/date-format/parse-MMMdy.js View 1 chunk +10 lines, -4 lines 0 comments Download
M test/intl/date-format/parse-mdyhms.js View 1 3 chunks +13 lines, -5 lines 0 comments Download
M test/intl/intl.status View 1 chunk +0 lines, -6 lines 0 comments Download
M test/intl/number-format/parse-decimal.js View 1 1 chunk +19 lines, -6 lines 0 comments Download
M test/intl/number-format/parse-percent.js View 1 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Dan Ehrenberg
I'm surprised that these pass, given that unshipping --intl-extra is shipped. Don't these need // ...
4 years, 7 months ago (2016-05-18 23:50:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988073003/1
4 years, 7 months ago (2016-05-18 23:51:10 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 00:19:19 UTC) #10
jungshik at Google
On 2016/05/18 23:50:53, Dan Ehrenberg wrote: > I'm surprised that these pass, given that unshipping ...
4 years, 7 months ago (2016-05-19 00:32:19 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988073003/20001
4 years, 6 months ago (2016-05-27 09:04:39 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 09:31:54 UTC) #15
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-05-27 09:50:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988073003/20001
4 years, 6 months ago (2016-05-27 17:54:29 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 17:57:27 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:59:29 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72d86e377245f2c91c59294d4f84092810154ae2
Cr-Commit-Position: refs/heads/master@{#36555}

Powered by Google App Engine
This is Rietveld 408576698