ct/go/master_scripts/run_chromium_perf_on_workers/main.go - Issue 1988073002: Add ability to only upload a single Chromium build and check for patch existence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ct/go/master_scripts/run_chromium_perf_on_workers/main.go

Issue 1988073002: Add ability to only upload a single Chromium build and check for patch existence (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Simplify conditional Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ct/go/master_scripts/run_chromium_perf_on_workers/main.go

diff --git a/ct/go/master_scripts/run_chromium_perf_on_workers/main.go b/ct/go/master_scripts/run_chromium_perf_on_workers/main.go

index 4bd170960a16432c2fac8d9f4b9d0795fc896a0e..b400ec74adfcf56b23c35abdc0c3b39bf69e6712 100644

--- a/ct/go/master_scripts/run_chromium_perf_on_workers/main.go

+++ b/ct/go/master_scripts/run_chromium_perf_on_workers/main.go

@@ -165,7 +165,7 @@ func main() {

benchmarkPatchLink = util.GS_HTTP_LINK + filepath.Join(util.GSBucketName, remoteOutputDir, benchmarkPatchName)

// Create the two required chromium builds (with patch and without the patch).

- chromiumHash, skiaHash, err := util.CreateChromiumBuild(*runID, *targetPlatform, "", "", true)

+ chromiumHash, skiaHash, err := util.CreateChromiumBuild(*runID, *targetPlatform, "", "", true, false)

if err != nil {

glog.Errorf("Could not create chromium build: %s", err)

return

« no previous file with comments | « ct/go/master_scripts/build_chromium/main.go ('k') | ct/go/util/chromium_builds.go » ('j') | no next file with comments »