Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1988063002: Use SVGInlineTextMetricsIterator in updateLayoutAttributes (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SVGInlineTextMetricsIterator in updateLayoutAttributes This reuses a pre-existing piece to do the "dual offset/variable" iteration, hiding (and sharing) the complexity. BUG=607906 Committed: https://crrev.com/7730dd28f370e4f0614b31af83fd600e81f1c18c Cr-Commit-Position: refs/heads/master@{#394412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 7 months ago (2016-05-18 12:24:12 UTC) #2
davve
lgtm
4 years, 7 months ago (2016-05-18 13:59:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988063002/1
4 years, 7 months ago (2016-05-18 14:13:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 14:20:39 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:21:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7730dd28f370e4f0614b31af83fd600e81f1c18c
Cr-Commit-Position: refs/heads/master@{#394412}

Powered by Google App Engine
This is Rietveld 408576698