media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG=596522
Committed: https://crrev.com/66881c9f9e22cdd1d7dca58c5b9191069e20346e
Cr-Commit-Position: refs/heads/master@{#395076}

[Srirama, 2016-05-19 14:29:16]

Description was changed from

==========
fix

BUG=
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG=596522
==========

[Srirama, 2016-05-19 14:31:01]

srirama.m@samsung.com changed reviewers:
+ rtoy@chromium.org

[Srirama, 2016-05-19 14:31:02]

PTAL

[Raymond Toy, 2016-05-19 14:48:42]

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
(right):

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp:76:
DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") -
unhandled format change";
How did you decide on 3?

Doesn't WTF_LOG always produce an output?  DVLOG(3) will only produce an output
if user has set up debugging logging at level 3, right?  If this is so, don't we
want to preserve WTF_LOG behavior?

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
(right):

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp:63:
DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") -
unhandled format change";
Same comment as for MediaElementAudioSource

[Srirama, 2016-05-19 14:54:44]

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
(right):

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp:76:
DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") -
unhandled format change";
On 2016/05/19 14:48:42, Raymond Toy wrote:
> How did you decide on 3?
> 
> Doesn't WTF_LOG always produce an output?  DVLOG(3) will only produce an
output
> if user has set up debugging logging at level 3, right?  If this is so, don't
we
> want to preserve WTF_LOG behavior?

We are using 3 in core/html media files, to make it less verbose
9https://codereview.chromium.org/1988753002/). So i just followed same here.
Probably we can use 1 here as there are less logs compared to core/html?

[Raymond Toy, 2016-05-19 15:31:37]

lgtm, with nit

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
(right):

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp:76:
DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") -
unhandled format change";
On 2016/05/19 at 14:54:44, Srirama wrote:
> On 2016/05/19 14:48:42, Raymond Toy wrote:
> > How did you decide on 3?
> > 
> > Doesn't WTF_LOG always produce an output?  DVLOG(3) will only produce an
output
> > if user has set up debugging logging at level 3, right?  If this is so,
don't we
> > want to preserve WTF_LOG behavior?
> 
> We are using 3 in core/html media files, to make it less verbose
9https://codereview.chromium.org/1988753002/). So i just followed same here.
Probably we can use 1 here as there are less logs compared to core/html?

I see.

I think these are fairly rare.  Can we just make it always output a message? 
When the condition fails and there's no message, it's really hard to figure out
why there's no audio anymore.

[Srirama, 2016-05-20 07:33:39]

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
(right):

https://codereview.chromium.org/1988053005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp:76:
DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") -
unhandled format change";
On 2016/05/19 15:31:37, Raymond Toy wrote:
> On 2016/05/19 at 14:54:44, Srirama wrote:
> > On 2016/05/19 14:48:42, Raymond Toy wrote:
> > > How did you decide on 3?
> > > 
> > > Doesn't WTF_LOG always produce an output?  DVLOG(3) will only produce an
> output
> > > if user has set up debugging logging at level 3, right?  If this is so,
> don't we
> > > want to preserve WTF_LOG behavior?
> > 
> > We are using 3 in core/html media files, to make it less verbose
> 9https://codereview.chromium.org/1988753002/). So i just followed same here.
> Probably we can use 1 here as there are less logs compared to core/html?
> 
> I see.
> 
> I think these are fairly rare.  Can we just make it always output a message? 
> When the condition fails and there's no message, it's really hard to figure
out
> why there's no audio anymore.

Even WTF_LOG will print only in debug mode and if user enables it through
-blink-platform-log-channels=Media command line switch. Anyway i found DLOG
which will print always in Debug mode. I think that should solve our purpose. So
is it fine?

[Raymond Toy, 2016-05-20 14:06:31]

lgtm.

Thanks for fixing that!

[Srirama, 2016-05-20 14:16:28]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-05-20 14:16:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988053005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988053005/40001

[commit-bot: I haz the power, 2016-05-20 15:42:33]

Description was changed from

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG=596522
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG=596522
==========

[commit-bot: I haz the power, 2016-05-20 15:42:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 15:44:01]

Description was changed from

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG=596522
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG=596522

Committed: https://crrev.com/66881c9f9e22cdd1d7dca58c5b9191069e20346e
Cr-Commit-Position: refs/heads/master@{#395076}
==========

[commit-bot: I haz the power, 2016-05-20 15:44:02]

Patchset 3 (id:??) landed as
https://crrev.com/66881c9f9e22cdd1d7dca58c5b9191069e20346e
Cr-Commit-Position: refs/heads/master@{#395076}