Issue 1988053002: Revert of cc: Refactor layer/tile manager unittest to extract common code. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(114)

My Issues | Starred Open | Closed | All

Issue 1988053002: Revert of cc: Refactor layer/tile manager unittest to extract common code. (Closed)

Created:
4 years, 7 months ago by Sami

Modified:
4 years, 7 months ago

Reviewers:
danakj, vmpstr, enne (OOO)

CC:
cc-bugs_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of cc: Refactor layer/tile manager unittest to extract common code. (patchset #3 id:40001 of https://codereview.chromium.org/1974033004/ ) Reason for revert: Looks like this made the tile manager perf test fail on every run: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/16351 Original issue's description: > cc: Refactor layer/tile manager unittest to extract common code. > > This patch introduces a new test base that can be used to easily setup > a layer tree host with some layers. This is already used in picture > layer impl tests and in tile manager unit/perf tests. Now, we can also > write new tests without copy/pasting this class. > > R=danakj, enne > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc > Cr-Commit-Position: refs/heads/master@{#393658} TBR=enne@chromium.org,danakj@chromium.org,vmpstr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/b04decf665de97eb612831eb664c8346b0c7032b Cr-Commit-Position: refs/heads/master@{#394383}

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1768 lines, -1643 lines)			Patch
	M	cc/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	cc/cc_tests.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	cc/layers/picture_layer_impl_unittest.cc	View		151 chunks	+1186 lines, -1056 lines	0 comments	Download
	D	cc/test/test_layer_tree_host_base.h	View		1 chunk	+0 lines, -83 lines	0 comments	Download
	D	cc/test/test_layer_tree_host_base.cc	View		1 chunk	+0 lines, -180 lines	0 comments	Download
	M	cc/tiles/tile_manager_perftest.cc	View		10 chunks	+116 lines, -38 lines	0 comments	Download
	M	cc/tiles/tile_manager_unittest.cc	View		62 chunks	+466 lines, -282 lines	0 comments	Download

Messages

Total messages: 9 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sami

Created Revert of cc: Refactor layer/tile manager unittest to extract common code.

4 years, 7 months ago (2016-05-18 10:26:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988053002/1

4 years, 7 months ago (2016-05-18 10:26:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988053002/1

4 years, 7 months ago (2016-05-18 10:30:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988053002/1

4 years, 7 months ago (2016-05-18 11:01:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988053002/1

4 years, 7 months ago (2016-05-18 11:31:03 UTC) #5

commit-bot: I haz the power

Description was changed from ========== Revert of cc: Refactor layer/tile manager unittest to extract common ...

4 years, 7 months ago (2016-05-18 11:38:44 UTC) #6

Message was sent while issue was closed.

Description was changed from

==========
Revert of cc: Refactor layer/tile manager unittest to extract common code.
(patchset #3 id:40001 of https://codereview.chromium.org/1974033004/ )

Reason for revert:
Looks like this made the tile manager perf test fail on every run:

https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/bu...

Original issue's description:
> cc: Refactor layer/tile manager unittest to extract common code.
> 
> This patch introduces a new test base that can be used to easily setup
> a layer tree host with some layers. This is already used in picture
> layer impl tests and in tile manager unit/perf tests. Now, we can also
> write new tests without copy/pasting this class.
> 
> R=danakj, enne
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc
> Cr-Commit-Position: refs/heads/master@{#393658}

TBR=enne@chromium.org,danakj@chromium.org,vmpstr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of cc: Refactor layer/tile manager unittest to extract common code.
(patchset #3 id:40001 of https://codereview.chromium.org/1974033004/ )

Reason for revert:
Looks like this made the tile manager perf test fail on every run:

https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/bu...

Original issue's description:
> cc: Refactor layer/tile manager unittest to extract common code.
> 
> This patch introduces a new test base that can be used to easily setup
> a layer tree host with some layers. This is already used in picture
> layer impl tests and in tile manager unit/perf tests. Now, we can also
> write new tests without copy/pasting this class.
> 
> R=danakj, enne
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc
> Cr-Commit-Position: refs/heads/master@{#393658}

TBR=enne@chromium.org,danakj@chromium.org,vmpstr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

commit-bot: I haz the power

Description was changed from ========== Revert of cc: Refactor layer/tile manager unittest to extract common ...

4 years, 7 months ago (2016-05-18 11:41:18 UTC) #8

Message was sent while issue was closed.

Description was changed from

==========
Revert of cc: Refactor layer/tile manager unittest to extract common code.
(patchset #3 id:40001 of https://codereview.chromium.org/1974033004/ )

Reason for revert:
Looks like this made the tile manager perf test fail on every run:

https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/bu...

Original issue's description:
> cc: Refactor layer/tile manager unittest to extract common code.
> 
> This patch introduces a new test base that can be used to easily setup
> a layer tree host with some layers. This is already used in picture
> layer impl tests and in tile manager unit/perf tests. Now, we can also
> write new tests without copy/pasting this class.
> 
> R=danakj, enne
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc
> Cr-Commit-Position: refs/heads/master@{#393658}

TBR=enne@chromium.org,danakj@chromium.org,vmpstr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of cc: Refactor layer/tile manager unittest to extract common code.
(patchset #3 id:40001 of https://codereview.chromium.org/1974033004/ )

Reason for revert:
Looks like this made the tile manager perf test fail on every run:

https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/bu...

Original issue's description:
> cc: Refactor layer/tile manager unittest to extract common code.
>
> This patch introduces a new test base that can be used to easily setup
> a layer tree host with some layers. This is already used in picture
> layer impl tests and in tile manager unit/perf tests. Now, we can also
> write new tests without copy/pasting this class.
>
> R=danakj, enne
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc
> Cr-Commit-Position: refs/heads/master@{#393658}

TBR=enne@chromium.org,danakj@chromium.org,vmpstr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Committed: https://crrev.com/b04decf665de97eb612831eb664c8346b0c7032b
Cr-Commit-Position: refs/heads/master@{#394383}
==========

commit-bot: I haz the power

4 years, 7 months ago (2016-05-18 11:41:21 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b04decf665de97eb612831eb664c8346b0c7032b
Cr-Commit-Position: refs/heads/master@{#394383}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698