Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

Issue 1988023010: Toolbar is a root layer for the UI compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
index 8d67ebe264376ebaf0c61ab2866a85f9f7622ec8..f44df724948eae71652d450bdefba401a9b2a668 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
@@ -1131,6 +1131,7 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene
// filter added should have the first chance to intercept any touch events.
for (int i = mSceneOverlays.size() - 1; i >= 0; i--) {
EventFilter eventFilter = mSceneOverlays.get(i).getEventFilter();
+ if (eventFilter == null) continue;
if (offsets != null) eventFilter.setCurrentMotionEventOffsets(offsets.x, offsets.y);
if (eventFilter.onInterceptTouchEvent(e, isKeyboardShowing)) return eventFilter;
}
@@ -1145,7 +1146,8 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene
/**
* Build a {@link SceneLayer} if it hasn't already been built, and update it and return it.
*
- * @param contentViewport A viewport in which to display content.
+ * @param viewport A viewport in which to display content.
+ * @param contentViewport The visible section of the viewport.
* @param layerTitleCache A layer title cache.
* @param tabContentManager A tab content manager.
* @param resourceManager A resource manager.
@@ -1153,10 +1155,9 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene
* @return A {@link SceneLayer} that represents the content for this
* {@link Layout}.
*/
- public final SceneLayer getUpdatedSceneLayer(Rect viewport,
- Rect contentViewport, LayerTitleCache layerTitleCache,
- TabContentManager tabContentManager, ResourceManager resourceManager,
- ChromeFullscreenManager fullscreenManager) {
+ public final SceneLayer getUpdatedSceneLayer(Rect viewport, Rect contentViewport,
+ LayerTitleCache layerTitleCache, TabContentManager tabContentManager,
+ ResourceManager resourceManager, ChromeFullscreenManager fullscreenManager) {
updateSceneLayer(viewport, contentViewport, layerTitleCache, tabContentManager,
resourceManager, fullscreenManager);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698