Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tool/input_sdk/private/ddc_runtime/rtti.dart

Issue 1988023008: Name and hoist types (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/private/ddc_runtime/rtti.dart
diff --git a/tool/input_sdk/private/ddc_runtime/rtti.dart b/tool/input_sdk/private/ddc_runtime/rtti.dart
index f62470ece91b4dc530b0240d8195ce2cad1c58c7..06bb28610c731fab5e12643c0a83a210fe1a522b 100644
--- a/tool/input_sdk/private/ddc_runtime/rtti.dart
+++ b/tool/input_sdk/private/ddc_runtime/rtti.dart
@@ -55,28 +55,20 @@ part of dart._runtime;
/// Note that since we are producing a type for a concrete function,
/// it is sound to use the definite arrow type.
///
-fn(closure, rType, argsT, extras) {
- var t;
- if (rType == null) {
+fn(closure, t) {
+ if (t == null) {
// No type arguments, it's all dynamic
t = definiteFunctionType(
JS('', '#', dynamic),
JS('', 'Array(#.length).fill(#)', closure, dynamic),
JS('', 'void 0'));
- } else {
- // We're passed the piecewise components of the function type,
- // construct it.
- t = definiteFunctionType(rType, argsT, extras);
}
tag(closure, t);
return closure;
}
-lazyFn(closure, computeTypeParts) {
- tagLazy(closure, JS('', '''() => {
- let parts = #();
- return #(parts[0], parts[1], parts[2]);
- }''', computeTypeParts, definiteFunctionType));
+lazyFn(closure, computeType) {
+ tagLazy(closure, computeType);
return closure;
}
« lib/src/compiler/compiler.dart ('K') | « tool/input_sdk/private/ddc_runtime/operations.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698