Name and hoist types

lib/src/compiler/compiler.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashSet;
 import 'package:args/args.dart' show ArgParser, ArgResults;
 import 'package:analyzer/analyzer.dart'
     show
         AnalysisError,
         CompilationUnit,
@@ skipping 141 matching lines @@
 
   /// Whether to preserve metdata only accessible via mirrors
   final bool emitMetadata;
 
   /// Whether to force compilation of code with static errors.
   final bool unsafeForceCompile;
 
   /// Whether to emit Closure Compiler-friendly code.
   final bool closure;
 
+  /// Hoist the types at instance creation sites
+  final bool hoistInstanceCreation;
+
+  /// Hoist types from class signatures
+  final bool hoistSignatureTypes;
+
+  /// Name types in type tests
+  final bool nameTypeTests;
+
+  /// Hoist types in type tests
+  final bool hoistTypeTests;
+
   /// Enable ES6 destructuring of named parameters. Off by default.
   ///
   /// Older V8 versions do not accept default values with destructuring in
   /// arrow functions yet (e.g. `({a} = {}) => 1`) but happily accepts them
   /// with regular functions (e.g. `function({a} = {}) { return 1 }`).
   ///
   /// Supporting the syntax:
   /// * Chrome Canary (51)
   /// * Firefox
   ///
   /// Not yet supporting:
   /// * Atom (1.5.4)
   /// * Electron (0.36.3)
   // TODO(ochafik): Simplify this code when our target platforms catch up.
   final bool destructureNamedParams;
 
   /// Which module format to support.
   /// Currently 'es6' and 'legacy' are supported.
   final ModuleFormat moduleFormat;
 
   const CompilerOptions(
       {this.sourceMap: true,
       this.sourceMapComment: true,
       this.summarizeApi: true,
       this.unsafeForceCompile: false,
       this.emitMetadata: false,
       this.closure: false,
       this.destructureNamedParams: false,
-      this.moduleFormat: ModuleFormat.legacy});
+      this.moduleFormat: ModuleFormat.legacy,
+      this.hoistInstanceCreation: true,
+      this.hoistSignatureTypes: false,
+      this.nameTypeTests: true,
+      this.hoistTypeTests: true});
 
   CompilerOptions.fromArguments(ArgResults args)
       : sourceMap = args['source-map'],
         sourceMapComment = args['source-map-comment'],
         summarizeApi = args['summarize'],
         unsafeForceCompile = args['unsafe-force-compile'],
         emitMetadata = args['emit-metadata'],
         closure = args['closure-experimental'],
         destructureNamedParams = args['destructure-named-params'],
-        moduleFormat = parseModuleFormat(args['modules']);
+        moduleFormat = parseModuleFormat(args['modules']),
+        hoistInstanceCreation = args['hoist-instance-creation'],
+        hoistSignatureTypes = args['hoist-signature-types'],
+        nameTypeTests = args['name-type-tests'],
+        hoistTypeTests = args['hoist-type-tests'];
 
   static ArgParser addArguments(ArgParser parser) => parser
     ..addFlag('summarize', help: 'emit an API summary file', defaultsTo: true)
     ..addFlag('source-map', help: 'emit source mapping', defaultsTo: true)
     ..addFlag('source-map-comment',
         help: 'adds a sourceMappingURL comment to the end of the JS,\n'
             'disable if using X-SourceMap header',
         defaultsTo: true)
     ..addOption('modules',
         help: 'module pattern to emit',
         allowed: ['es6', 'legacy', 'node'],
         allowedHelp: {
           'es6': 'es6 modules',
           'legacy': 'a custom format used by dartdevc, similar to AMD',
           'node': 'node.js modules (https://nodejs.org/api/modules.html)'
         },
         defaultsTo: 'legacy')
     ..addFlag('emit-metadata',
         help: 'emit metadata annotations queriable via mirrors',
         defaultsTo: false)
     ..addFlag('closure-experimental',
         help: 'emit Closure Compiler-friendly code (experimental)',
         defaultsTo: false)
     ..addFlag('destructure-named-params',
         help: 'Destructure named parameters', defaultsTo: false)
     ..addFlag('unsafe-force-compile',
         help: 'Compile code even if it has errors. ಠ_ಠ\n'
             'This has undefined behavior!',
-        defaultsTo: false);
+        defaultsTo: false)
+    ..addFlag('hoist-instance-creation',

[Jennifer Messerly, 2016/05/25 01:24:18]

Should we hide these options from the "--help"? I think there's a boolean that
does that. (hide: true?)

+        help: 'Hoist the class type from generic instance creations',
+        defaultsTo: true)
+    ..addFlag('hoist-signature-types',
+        help: 'Hoist types from class signatures', defaultsTo: false)
+    ..addFlag('name-type-tests',
+        help: 'Name types used in type tests', defaultsTo: true)
+    ..addFlag('hoist-type-tests',
+        help: 'Hoist types used in type tests', defaultsTo: true);
 }
 
 /// A unit of Dart code that can be built into a single JavaScript module.
 class BuildUnit {
   /// The name of this module.
   final String name;
 
   /// Build root.  All library names are relative to this path/prefix.
   final String buildRoot;
 
@@ skipping 68 matching lines @@
   }
 }
 
 /// (Public for tests) the error code used when a part is missing.
 final missingPartErrorCode = const CompileTimeErrorCode(
     'MISSING_PART', 'The part was not supplied as an input to the compiler.');
 
 /// (Public for tests) the error code used when a part is unused.
 final unusedPartWarningCode = const StaticWarningCode(
     'UNUSED_PART', 'The part was not used by any libraries being compiled.');