Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1988023007: [Android] Move test suites from Android GN over to Android Tests{, (dbg)}. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move test suites from Android GN over to Android Tests{, (dbg)}. This includes: - ipc_mojo_unittests - mojo_common_unittests - mojo_public_application_unittests - mojo_public_bindings_unittests - mojo_public_system_unittests - mojo_runner_host_unittests - mojo_surfaces_lib_unittests BUG=610839 Committed: https://crrev.com/0daa70eae2543b93f14edf029e91ed72129b3e2f Cr-Commit-Position: refs/heads/master@{#394855}

Patch Set 1 #

Patch Set 2 : disabled part of failing mojo test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -183 lines) Patch
M testing/buildbot/chromium.linux.json View 1 6 chunks +50 lines, -183 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jbudorick
Addressed the one test that failed in mojo_public_bindings_unittests in PS1's try jobs in https://codereview.chromium.org/1991233002/
4 years, 7 months ago (2016-05-19 15:26:14 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-19 18:31:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988023007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988023007/20001
4 years, 7 months ago (2016-05-19 18:38:07 UTC) #5
ghost stip (do not use)
lgtm
4 years, 7 months ago (2016-05-19 19:04:22 UTC) #6
jbudorick
+mdjones: sheriff fyi
4 years, 7 months ago (2016-05-19 19:05:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 20:48:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:50:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0daa70eae2543b93f14edf029e91ed72129b3e2f
Cr-Commit-Position: refs/heads/master@{#394855}

Powered by Google App Engine
This is Rietveld 408576698