Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1988023006: mac: Make `find_sdk.py --print_sdk_path` much faster. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Make `find_sdk.py --print_sdk_path` much faster. Use xcrun instead of xcodebuild if --print_sdk_path is passed. Reduces time to run `gn gen` from 2.2s to 1.95s on my MacBook Pro. (In the gyp build, we don't pass --print_sdk_path to this script, so I didn't notice this script had this slow path until now.) While here, also stop pretending that we support Xcodes older than 4.3. BUG=609541 Committed: https://crrev.com/d50140bae570f519cea29a8b20e58511032cbfd7 Cr-Commit-Position: refs/heads/master@{#394565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M build/mac/find_sdk.py View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
first to stamp wins!
4 years, 7 months ago (2016-05-18 21:04:06 UTC) #2
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-18 21:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988023006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988023006/1
4 years, 7 months ago (2016-05-18 21:12:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 22:00:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d50140bae570f519cea29a8b20e58511032cbfd7 Cr-Commit-Position: refs/heads/master@{#394565}
4 years, 7 months ago (2016-05-18 22:02:46 UTC) #8
sdefresne
4 years, 7 months ago (2016-05-19 09:18:22 UTC) #9
Message was sent while issue was closed.
lgtm

I'm late to the game!

Powered by Google App Engine
This is Rietveld 408576698